Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added better logo file validation #8934

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Added better logo file validation #8934

merged 1 commit into from
Oct 26, 2023

Conversation

GilbertCherrie
Copy link
Member

Added more validation to the Settings > Application Settings > Custom Logos upload functionality. Added more checks to ensure validity of logo files being uploaded.

@GilbertCherrie GilbertCherrie requested a review from Fryguy October 13, 2023 20:16
@GilbertCherrie GilbertCherrie requested a review from a team as a code owner October 13, 2023 20:16
@Fryguy
Copy link
Member

Fryguy commented Oct 13, 2023

@GilbertCherrie Let's see if we can add specs for this.

@GilbertCherrie GilbertCherrie force-pushed the add_logo_file_validation branch from 3d2a691 to 92e241c Compare October 16, 2023 13:27
@GilbertCherrie GilbertCherrie force-pushed the add_logo_file_validation branch 2 times, most recently from f112c71 to 5a1af40 Compare October 16, 2023 15:58
@GilbertCherrie
Copy link
Member Author

@Fryguy I added the rspecs if you can review again when you have time

@GilbertCherrie GilbertCherrie force-pushed the add_logo_file_validation branch 3 times, most recently from e0cffd7 to 600f52b Compare October 16, 2023 20:25
@GilbertCherrie GilbertCherrie force-pushed the add_logo_file_validation branch from 600f52b to d4d397c Compare October 17, 2023 16:42
@Fryguy Fryguy merged commit 06d900c into ManageIQ:master Oct 26, 2023
15 checks passed
@Fryguy
Copy link
Member

Fryguy commented Oct 27, 2023

Skipping backport to quinteros, because it is already in the branch.

@GilbertCherrie GilbertCherrie deleted the add_logo_file_validation branch October 27, 2023 16:46
@Fryguy
Copy link
Member

Fryguy commented Nov 20, 2023

Backported to morphy in commit 8abc37b.

commit 8abc37b7e8f0fa048db7f24464192ff4d775ab6d
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Oct 26 11:02:29 2023 -0400

    Merge pull request #8934 from GilbertCherrie/add_logo_file_validation
    
    Added better logo file validation
    
    (cherry picked from commit 06d900c3f318c7c8e91611fb30111c6b69117d7e)

Fryguy added a commit that referenced this pull request Nov 20, 2023
@Fryguy
Merge pull request #8934 from GilbertCherrie/add_logo_file_validation
8abc37b 
Added better logo file validation

(cherry picked from commit 06d900c)
@Fryguy Fryguy mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
enhancement morphy/backported petrosian/yes?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GilbertCherrie @Fryguy