Drop sass rails #9286
Merged
Drop sass rails #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot cross-repo-test /all Technically we don't need all, but only those reps with JavaScript compilation, but I'm lazy haha |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 18, 2024
From Pull Request: ManageIQ/manageiq-ui-classic#9286
|
@kbrock I noticed you also added the Ruby 3.2 and 3.3 testing in here. Was that intentional or should that be done through a separate pr |
|
thanks. separate PR |
|
@kbrock Did you test rpm building with this? |
|
@Fryguy once I get in dropping sass, then rpm builds work with this. |
We are using webpacker (via the command line) to build sass assets. This is disabled in production And developers are using either rake update:ui or webpack --watch So no need to include this in our dev chain.
kbrock
force-pushed
the
drop_sass_rails
branch
from
50266b2
to
042f3f3
Compare
|
update:
@Fryguy tested building rpms with ruby 3.1 |
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.