Add missing icons for provider policies & compliance events

[cben]

Followup to ManageIQ/manageiq#11002,
https://bugzilla.redhat.com/show_bug.cgi?id=1411337 (master)
https://bugzilla.redhat.com/show_bug.cgi?id=1411364 (euwe)

Before:

After (this PR only fixes icons, event name fixed in core PR ManageIQ/manageiq#13388):

miq_policy_extmanagementsystem_inactive.png made with red "X" imperfectly stolen from other _inactive icons.

[cben]

@epwinchell Please review

[skateman]

@cben I think this is a regression that will be fixed by merging #128, could you please verify it? We want to get rid of the PNG files and use fonticons where possible.

[epwinchell]

@skateman I found one additional screen not using the decorator: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/miq_policy/_event_details.html.haml#L13

[skateman]

@epwinchell this should do it:

%i{:class => @event.decorate.fonticon}

[cben]

Cool, checking...

@miq-bot add-label euwe/yes
(euwe BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1411364)
#128 is euwe/no, so perhaps this is still needed.

[epwinchell]

@cben PR looks fine

[epwinchell]

@miq-bot add_label bug

[epwinchell]

@miq-bot assign @himdel

[cben]

Hmm, this won't merge as-is to uewe, miq_event_definition_decorator.rb was much smaller then.

However. no, #128 alone does not fix any of those icons.
It does make event-*png unnecessary, given the miq_event_definition_decorator.rb additions from this PR.
miq_policy_*png are still needed, git grep 100/miq_policy_ still returns 8 places it's used.

Oops I forgot miq_policy_extmanagementsystem_inactive.png. FIXED
@miq-bot add-label wip

[epwinchell]

@cben Doing a separate PR for Euwe with just the images should take care of it.

[miq-bot]

Checked commits cben/manageiq-ui-classic@c4bc393~...fbf0c84 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍰

[cben]

Added inactive policy icon (see last screenshot).
@miq-bot remove-label wip

Kept event-*.png files in this PR, so this may be merged before #128. The other event-*.png files still exist, you'll later be able to delete 176 instead of 173 of them...

Created euwe PR ManageIQ/manageiq#13502.

[cben]

Ping, any chance to merge & backport before euwe-2 release?

[simaishi]

Backported to Euwe via ManageIQ/manageiq#13502