Catch SSLError too when adding a provider #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands ManageIQ#314. KubeException already covers the common "certificate verify failed" SSL errors but not rarer ones like "does not match the server certificate". This might be resolved in Kubeclient or RestClient one day (ManageIQ/kubeclient#240) but it's blocked on backward compatibility concerns so let's catch it here for now. get_hostname_from_routes is best-effort, should never crash UI. Any SSL error will probably fail both get_hostname_from_routes and the main validation code; the error from validation will then be displayed in a red flash. https://bugzilla.redhat.com/show_bug.cgi?id=1436221
|
Checked commit cben@7e2bc52 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
moolitayer
approved these changes
Apr 9, 2017
There was a problem hiding this comment.
Per discussion in kubeclient I think this is the correct solution long term (depends if/how rest-client/rest-client#168 will be resolved)
simaishi
pushed a commit
that referenced
this pull request
Apr 11, 2017
Catch SSLError too when adding a provider (cherry picked from commit bc446e5)
|
Fine backport details: |
cben
added a commit
to cben/manageiq-ui-classic
that referenced
this pull request
Apr 23, 2017
ManageIQ#972 was not enough, e.g. OpenSSL::X509::CertificateError parsing errors still spill through. turns out OpenSSL::SSL::SSLError is not the parent of all openssl errors, that would be OpenSSL::OpenSSLError. But I won't repeating the mistake a third time, let's catch everything. This function is a best-effort guess anyway. https://bugzilla.redhat.com/show_bug.cgi?id=1436221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands #314.
KubeException already covers the common "certificate verify failed" SSL errors but not rarer ones like "does not match the server certificate".
This might be resolved in Kubeclient or RestClient one day (ManageIQ/kubeclient#240) but it's blocked on backward compatibility concerns so let's catch it here for now.
So currently some SSL errors can crash
get_hostname_from_routesleading to no indication except stacktrace in log:This has also been observed as a "Unexpected error encountered" screen which does show the error but makes it hard to proceed.
https://bugzilla.redhat.com/show_bug.cgi?id=1436221
Any SSL error will probably fail both
get_hostname_from_routesand the main validation code.With this fix, the error from validation will then be displayed in a red flash:
@miq-bot add-label compute/containers, bug, blocker, fine/yes
(per flags on https://bugzilla.redhat.com/show_bug.cgi?id=1436221)
@moolitayer @h-kataria Please review.
P.S. @h-kataria I think ems_common controller used to be more robust, with errors showing in UI, and at some point became more fragile due to JS/JSON response mismatch.