Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Display Request Workflow for MiqProvisionRequest type of requests #414

Closed
wants to merge 21 commits into from
Closed

[WIP] Display Request Workflow for MiqProvisionRequest type of requests #414

wants to merge 21 commits into from

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jan 5, 2017 •
edited
Loading

Workflow tabs use the workflow object returned by the api/requests/<id>?attributes=workflow API (ManageIQ/manageiq#13254)

Progress so far...

Request, Purpose, Catalog, Environment and Hardware tab in both UIs

Classic UI:
screen shot 2017-01-05 at 10 37 17 am

screen shot 2017-01-11 at 10 50 34 am

screen shot 2017-01-16 at 3 41 59 pm

screen shot 2017-01-19 at 4 06 38 pm

screen shot 2017-01-25 at 4 15 32 pm

SUI:
screen shot 2017-01-05 at 11 13 52 am

screen shot 2017-01-11 at 10 50 59 am

screen shot 2017-01-16 at 3 39 26 pm

screen shot 2017-01-19 at 4 08 31 pm

screen shot 2017-01-25 at 4 15 21 pm

https://www.pivotaltracker.com/n/projects/1914499/stories/136994131

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot added the wip label Jan 5, 2017
@chriskacerguis chriskacerguis self-assigned this Jan 5, 2017
@chriskacerguis
Copy link
Contributor

@serenamarie125 can you please take a look at the UX here?

serenamarie125
serenamarie125 approved these changes Jan 6, 2017
View reviewed changes
Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AparnaKarve AparnaKarve force-pushed the display_vm_prov_request_tabs branch 3 times, most recently from 317018c to 21c2cec Compare January 16, 2017 23:30
@AparnaKarve AparnaKarve mentioned this pull request Jan 17, 2017
Closed
@AparnaKarve AparnaKarve force-pushed the display_vm_prov_request_tabs branch 2 times, most recently from 0c26be3 to bd12567 Compare January 19, 2017 23:29
@miq-bot
Copy link
Member

miq-bot commented Jan 20, 2017

This pull request is not mergeable. Please rebase and repush.

@chriskacerguis
Copy link
Contributor

@AparnaKarve could you please provide an update on where things are with this?

@AparnaKarve
Copy link
Contributor Author

@chriskacerguis
Short update:
4 tabs (Request, Purpose, Catalog, Environment) are done out of a total of 8.
Work very much in progress.

Long update:
One of the reasons why this is so time-consuming is because some tabs were in need of some API enhancements.
So far 5 API enhancement PRs were created for this story --
ManageIQ/manageiq#13254
ManageIQ/manageiq#13379
ManageIQ/manageiq#13441
ManageIQ/manageiq#13497
ManageIQ/manageiq#13574

For the remaining tabs, I do not think we need any more API enhancements.
But remember that this is just displaying the Workflow information. The next step would be Editing it, and at that point I'm expecting to add more API enhancements to populate the dropdowns etc.

@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2017

This pull request is not mergeable. Please rebase and repush.

@AparnaKarve
Add ng-if to display either the Provisiong dialog or the workflow
1f0a3ed
@AparnaKarve
Make the fieldsLayout function generic - applicable for most tabs
980066e
@AparnaKarve
Create tabs only for enabled dialogs
59b14b6
@AparnaKarve
Address gulp test failures
ae1e897
@AparnaKarve
Display the Catalog tab details
3899bd2
@AparnaKarve
Use v_workflow_class attribute to adjust labels in the catalog tab
8fa0131
@AparnaKarve
Tags tree component
c9c28ab
@AparnaKarve
Resolve lint failures
d87a6b9
@AparnaKarve
Add Environment tab fields
3920d5d
@AparnaKarve
Use options method to retrieve Cluster and Host names
5ac024b
@AparnaKarve
Changes per PR ManageIQ#450
b0cc8f5 
Add explicit import and export, convert app scripts to modules
@AparnaKarve
Add require for
f50a12e 
'patternfly-bootstrap-treeview/dist/bootstrap-treeview.min.js'
@AparnaKarve
Add Hardware tab details
d44fa8a 
fieldsLayout() was changed to filter out objects that contain
the `display` attribute
@AparnaKarve
Add Network tab details
b2e5f5a
@AparnaKarve
Major Refactor -- resolve CC similar code error
ec22970 
Similar code found in 1 other location (mass = 388)
@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2017

Checked commits AparnaKarve/manageiq-ui-self_service@5dc8e7a~...9abed13 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@AparnaKarve
Copy link
Contributor Author

One more API PR in the works that is required for this PR -- ManageIQ/manageiq#13672

@AllenBW
Copy link
Member

AllenBW commented Feb 3, 2017

@AparnaKarve so long as we git this in in under year, you have nothing to 😊 about 😆

@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2017

This pull request is not mergeable. Please rebase and repush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@AllenBW AllenBW Awaiting requested review from AllenBW

Assignees

@chriskacerguis chriskacerguis

Labels
enhancement unmergeable ux/review wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @chriskacerguis @miq-bot @AllenBW @serenamarie125