This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
[GAPRINDASHVILI] Adjusts printwidth to 120, ignores all strings for intl that exceed #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AparnaKarve
approved these changes
Jun 27, 2018
priley86
approved these changes
Jun 27, 2018
mzazrivec
approved these changes
Jun 28, 2018
|
thanks @kedark3 for the bz!!!! <3 🙇 |
|
Merge anyone? I'd like to rebase #440 on top of this one (thanks Allen). |
|
@simaishi Can you do the honors here? Thanks. |
|
@AllenBW @mzazrivec Both this PR and #440 are needed for https://bugzilla.redhat.com/show_bug.cgi?id=1596264 ? |
|
@simaishi correct! yeah its a catchall translation bz 😋 |
AllenBW
force-pushed
the
bug/gaprindashvili/adjust-printwidth-for-intl
branch
4 times, most recently
from
3d3f18c
to
cdcf324
Compare
|
@AllenBW @mzazrivec Sorry, I merged the other one first (please mark as WIP in the future for cases like this!) |
|
😭 ok will get to this in a bit |
AllenBW
force-pushed
the
bug/gaprindashvili/adjust-printwidth-for-intl
branch
from
cdcf324
to
39cf990
Compare
|
@simaishi okie dokie, we're g2g, yah did the right thing thou... this one was gonna cause trouble either way, either everything else backported would break or this one would, much prefer the single place to fix 😏 💟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1596264
Its like #443 CEPT FOR G
cc @mzazrivec
🎁