Migration Status string constants for i18n

[AparnaKarve]

Fixes #255

None of the Migration status strings from the backend were being addressed for i18n/gettext.

Thanks @AllenBW for noticing this in #468

I have included all the strings from -
https://github.com/ManageIQ/manageiq-content/blob/d0cbbf2eed56b75cb737c650ec72b1504c8a31b8/content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformation.yaml

and

https://github.com/ManageIQ/manageiq-content/blob/f0e6ca25f23ed4a88a87cdecc6f1066aa30898ec/content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/vmwarews2rhevm_vddk.yaml

that show up in the Plan detail page.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1600636

[AparnaKarve]

@fdupont-redhat It looks like the manageiq-content repo does not currently have a provision to extract strings for gettext.

I have captured all the Migration Status strings here for i18n that are visible in the UI.
Can you review these and let me know if I included them all?
Thanks!!

[AllenBW]

❤️ ❤️ ❤️

wonderfully executed @AparnaKarve!!

[ghost]

@AparnaKarve
It's probable that I will have more messages as I'm adding more states to the state machine. Should I also create PRs to add them?

[AparnaKarve]

@fdupont-redhat Yes, please.
As you add more messages to the state machine, you can create a PR in this repo and add the new messages under V2V_MIGRATION_STATUS_MESSAGES

[AparnaKarve]

@priley86 Can you review the third commit?
I have replaced the Transformation word with Migration in most cases, except one -
'Acquire Transformation Host'

[priley86]

this is much appreciated @AparnaKarve!

do you mind also updating the references in PlanRequestDetailListConstants.js:

export const ACTIVE_PLAN_FILTER_TYPES = [
  {
    id: 'vmName',
    title: __('VM Name'),
    placeholder: __('Filter by VM Name'),
    filterType: 'text'
  },
  {
    id: 'message',
    title: __('Status'),
    placeholder: __('Filter by Status'),
    filterType: 'select',
    filterValues: [
      { title: __('Pending'), id: 'Pending' },
      { title: __('Validating'), id: 'Validating' },
      { title: __('Pre-migration'), id: 'Pre-migration' },
      { title: __('Migrating'), id: 'Migrating' },
      {
        title: __('VM Transformations completed'),
        id: 'VM Transformations completed'
      },
      {
        title: __('VM Transformations failed'),
        id: 'VM Transformations failed'
      }
    ]
  }
];

These filter types should depend on those references now I think.

Otherwise LGTM.

[AparnaKarve]

@priley86 So, we don't need any changes in PlanRequestDetailListConstants.js.

Since we changed the Transformations word to Migrations in some cases, this has affected some areas where we actually check for the output'VM Transformations completed' or 'VM Transformations failed' -- hence I created constant values for those here 17512ba which I will be using for comparing with the API output.

[priley86]

@AparnaKarve - i think we can just expose those keys as another constant...and reference them there for consistency. Let me know if this works for you...seems to test OK here.

priley86@f464506

[priley86]

also - i think this now closes #255 😸

[AparnaKarve]

@priley86 Thank you for 0a9d9a6

@priley86 / @AllenBW This is GTG, IMO.

[AllenBW]

And the use of the keys 😻 Took me a sec to get it... buttttt this feels really solid, now we gotta remain vigilante, ensure they are USED

[AllenBW]

love love love this <3

[bthurber]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1600636

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit f93006142f5faec92bff97970c4bf8989613dbe6
Author: Allen Wight <allen.b.wight@gmail.com>
Date:   Wed Jul 11 17:57:46 2018 -0400

    Merge pull request #476 from AparnaKarve/i18n_migration_status_constants
    
    Migration Status string constants for i18n
    (cherry picked from commit 8646fc4446716884458026d4f309d8b5d9aa033b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608752