[#499] handle missing clusters, networks, storages

[priley86]

fixes #499
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602796

• Safeguard against deleted networks, datastorages, clusters in the infrastructure mapping list view.
• Ensure the UI will not break due to null references / missing values.
• Display "Clusters/Networks/Datastores missing" errors in the list.
• For simplicity, if there are any missing clusters, display missing data for networks/storages as well.

Tested this against the QE database w/ the missing LAN, and it will now display the following:

Here's how it would look if all were missing though:

It seems the original issue was that a provider was deleted. I will see how this checks out w/ that scenario shortly...

Update: testing this against the other scenario, which is deleting the RHV provider, and then adding it back. The UI will no longer crash and show the messaging above. Works as expected.

• Note: I personally think it is far too much additional logic to do all these checks in the Plan Wizard (and would just convolute the UI). In the future, the backend might flag these records for us and make that easier. For now, we will have to let the user run a migration which will likely fail. Still need to validate this scenario w/ QE, but the initial attempt here is to just prevent the UI from becoming unresponsive.

[AparnaKarve]

I personally think it is far too much additional logic to do all these checks in the Plan Wizard

Yes, agree.

@priley86 Tested this in the UI. Changes look good and prevent the UI from breaking.
You have covered all possible cases in this PR - clusters, datastores and lans, so I think the crash is well addressed for any of the "missing id" use cases.

Can I request one minor change?
Can you remove the period in these strings --
Networks missing./ Datastores missing. / Clusters missing.

[priley86]

good point - they are inconsistent with other labels, and PF does not include them...removing them now.

[AparnaKarve]

Works well, looks good!

[michaelkro]

Also tested using the QE database, works as expected 🎊

[kedark3]

@priley86 we don't have 19th July nightly yet, if we have it today, we can test it or on Monday.

[kedark3]

5.9.4.1 is still broken,https://bugzilla.redhat.com/show_bug.cgi?id=1602796#c9

Although, 5.10.0.6 is showing correctly as mentioned in #503 (comment)

[AparnaKarve]

This has not been backported to G yet, and hence 5.9.4.1 would appear to be broken.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit d7f9ab73a9bbe6abca8c46a7ab364e4841c5d80d
Author: Aparna Karve <aparna.karve@gmail.com>
Date:   Thu Jul 19 14:44:21 2018 -0700

    Merge pull request #503 from priley86/deleted-network
    
    [#499] handle missing clusters, networks, storages
    (cherry picked from commit 85699b77ecd60388760424974e6821ad24ceaf44)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610077