Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fix VM validity during Plan Edit #691

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Fix VM validity during Plan Edit #691

merged 1 commit into from
Oct 25, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve force-pushed the fix_edit_plan_with_same_vms_in_csv branch from 07f723d to 73daf39 Compare October 5, 2018 20:14
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commit AparnaKarve@73daf39 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@AparnaKarve
Copy link
Contributor Author

@michaelkro @mturley When you get a chance, can you test this PR?
Both backend PRs have been merged.
Thank you.

michaelkro
michaelkro approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great! 🎉

mturley
mturley approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end!

@michaelkro michaelkro merged commit d48f78d into ManageIQ:master Oct 25, 2018
@AparnaKarve AparnaKarve deleted the fix_edit_plan_with_same_vms_in_csv branch October 25, 2018 17:39
simaishi pushed a commit that referenced this pull request Oct 25, 2018
@michaelkro @simaishi
Merge pull request #691 from AparnaKarve/fix_edit_plan_with_same_vms_…
f2c4ceb 
…in_csv

Fix VM validity during Plan Edit

(cherry picked from commit d48f78d)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f2c4ceb030b5ff2d8b1c9aea0f3d6487e48ef490
Author: Michael Ro <mikerodev@gmail.com>
Date:   Thu Oct 25 13:38:54 2018 -0400

    Merge pull request #691 from AparnaKarve/fix_edit_plan_with_same_vms_in_csv
    
    Fix VM validity during Plan Edit
    
    (cherry picked from commit d48f78df33be45338c97de215eaf2ab342e7c3ae)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelkro michaelkro michaelkro approved these changes

@mturley mturley mturley approved these changes

Assignees
No one assigned
Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @miq-bot @simaishi @mturley @michaelkro