[#786] Handle denied state of a plan request (no conversion hosts configured) #798
Conversation
|
The card currently looks like this, and all attempts I've made so far at fixing that button positioning and footer sizing have caused the height-matching to squash the card height down to a point where the footer goes back to not being tall enough. 😡
Edit: |
mturley
force-pushed
the
786-plan-denied-state
branch
2 times, most recently
from
24d8fec
to
cb06944
Compare
mturley
force-pushed
the
786-plan-denied-state
branch
from
cb06944
to
51be7f6
Compare
mturley
force-pushed
the
786-plan-denied-state
branch
from
51be7f6
to
db8647b
Compare
mturley
changed the title
|
This will also fix #739. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const cardEmptyState = ( | ||
| <EmptyState> | ||
| <EmptyState.Icon type="pf" name="error-circle-o" /> | ||
| <EmptyState.Info style={{ marginTop: 10 }}> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| iconType="pf" | ||
| iconName="error-circle-o" | ||
| description={ | ||
| <React.Fragment> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mturley
force-pushed
the
786-plan-denied-state
branch
from
b66405e
to
70bd78b
Compare
mturley
changed the title
|
Checked commits mturley/manageiq-v2v@e79794a~...7b6d4ea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| return ( | ||
| (mostRecentRequest.request_state === 'finished' && mostRecentRequest.approval_state !== 'denied') || | ||
| mostRecentRequest.request_state === 'failed' || | ||
| (mostRecentRequest.approval_state === 'denied' && mostRecentRequest.options.denial_acknowledged) |
There was a problem hiding this comment.
Methinks we can remove the approval_state === 'denied' check here
|
@simaishi Could this be cherry-picked into hammer please? Thank you. |
[#786] Handle denied state of a plan request (no conversion hosts configured) (cherry picked from commit e8e89d1) https://bugzilla.redhat.com/show_bug.cgi?id=1640816
|
Hammer backport details: |
Fixes #786.
Fixes #739.
https://bugzilla.redhat.com/show_bug.cgi?id=1640816
deniedtest-denied-stateconditionDOCS_URL_CONFIGURE_CONVERSION_HOSTSURL, which is now a 404Screens
A denied plan in the Plans In Progress view:
A denied plan in the Plans Complete view:
A denied plan in the Plan Request Details view:
Recording