This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
[#740] Waiting for available conversion hosts #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| </EmptyState> | ||
| ); | ||
|
|
||
| CardEmptyState.propTypes = { |
There was a problem hiding this comment.
Similar blocks of code found in 11 locations. Consider refactoring.
| <CardEmptyState | ||
| iconType="pf" | ||
| iconName="error-circle-o" | ||
| emptyStateInfo={ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
3 times, most recently
from
458867b
to
d646a03
Compare
| .set('isRejectedCancelPlanRequest', false) | ||
| .set('hasRequestedCancellation', [...state.hasRequestedCancellation, action.payload]); | ||
| case `${V2V_CANCEL_PLAN_REQUEST}_FULFILLED`: { | ||
| return state |
There was a problem hiding this comment.
Avoid too many return statements within this function.
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
2 times, most recently
from
77d7d72
to
aa65469
Compare
| response: { data: cancelRequestResponse } | ||
| }); | ||
|
|
||
| return store.dispatch(cancelPlanRequestAction(TRANSFORMATION_PLAN_REQUESTS_URL, '1')).then(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| status: 404 | ||
| }); | ||
|
|
||
| return store.dispatch(cancelPlanRequestAction(TRANSFORMATION_PLAN_REQUESTS_URL, '1')).catch(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
3 times, most recently
from
17ae9a7
to
29681a8
Compare
| response: { data: cancelRequestResponse } | ||
| }); | ||
|
|
||
| return store.dispatch(action).then(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| status: 404 | ||
| }); | ||
|
|
||
| return store.dispatch(action).catch(() => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
4 times, most recently
from
9e6bdc0
to
33e2313
Compare
michaelkro
changed the title
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
from
33e2313
to
593658c
Compare
* When a cancelation is initiated for a plan request, its cancelation_status attribute will change from null to a string value * requestsProcessingCancellation * Scopes disabling cancel button to a specific in progress card * Cancel button will remain disabled even after a full page refresh
michaelkro
force-pushed
the
740-waiting-for-conversion-hosts
branch
from
593658c
to
392ef2e
Compare
|
Checked commits michaelkro/manageiq-v2v@e14c5d9~...392ef2e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mturley
reviewed
Nov 27, 2018
mturley
approved these changes
Nov 28, 2018
simaishi
pushed a commit
that referenced
this pull request
Dec 3, 2018
[#740] Waiting for available conversion hosts (cherry picked from commit ef4b7e1) https://bugzilla.redhat.com/show_bug.cgi?id=1640816
|
Hammer backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740
https://bugzilla.redhat.com/show_bug.cgi?id=1640816
Notes
cancelation_statusgets set to 'cancel_requested`, but does not progress to the other two states. Please see [699] Fix cancellation issues based on new backend changes #708MiqQueue.destroy_allScreens