Add skeleton for Configure Conversion Host wizard steps #863
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| this.setState({ activeStepIndex }); | ||
| }; | ||
|
|
||
| goToStepId = id => { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| <Button bsStyle="default" className="btn-cancel" onClick={hideConversionHostWizard} disabled={onFinalStep}> | ||
| {__('Cancel')} | ||
| </Button> | ||
| <Button bsStyle="default" onClick={this.prevStep} disabled={onFirstStep || onFinalStep}> |
There was a problem hiding this comment.
Identical blocks of code found in 3 locations. Consider refactoring.
| } | ||
| }; | ||
|
|
||
| render() { |
There was a problem hiding this comment.
Function render has 40 lines of code (exceeds 25 allowed). Consider refactoring.
|
Checked commits mturley/manageiq-v2v@d1f61ff~...0394921 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@michaelkro if you get a chance can you merge this? I may add unit tests later for the wizard container, but I'm not sure how useful they'll be at this stage and they may need to change anyway. The individual wizard steps will get more useful unit tests. |
Add skeleton for Configure Conversion Host wizard steps (cherry picked from commit f6ecbbc) https://bugzilla.redhat.com/show_bug.cgi?id=1696423
|
Hammer backport details: |
Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339
This is the first part of #855 and will enable us to develop the individual wizard steps in parallel.
This does not include any Redux reducers/actions for the individual steps, but creates an empty
index.jscontainer for each step so we can add those things as needed.