Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Conversion Hosts: add initial button for empty state screen #864

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversion Hosts: add initial button for empty state screen #864

merged 1 commit into from
Jan 29, 2019

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jan 29, 2019 •
edited by mturley
Loading

Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339

empty-state

Fixes: #854

@mzazrivec mzazrivec force-pushed the add_empty_state_for_coversion_hosts branch from edb350e to bf296e3 Compare January 29, 2019 10:18
@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2019

Checked commit mzazrivec@bf296e3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

michaelkro
michaelkro approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

mturley
mturley approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mzazrivec.

@mturley mturley merged commit eab39c4 into ManageIQ:master Jan 29, 2019
@mzazrivec mzazrivec deleted the add_empty_state_for_coversion_hosts branch January 30, 2019 06:54
@mturley mturley added bz Issues filed by QE or having a BZ and removed bugzilla needed labels Feb 27, 2019
@mturley mturley added v1.2 and removed v1.1 labels Mar 25, 2019
simaishi pushed a commit that referenced this pull request Apr 5, 2019
@mturley @simaishi
Merge pull request #864 from mzazrivec/add_empty_state_for_coversion_…
8b3ee76 
…hosts

Conversion Hosts: add initial button for empty state screen

(cherry picked from commit eab39c4)

https://bugzilla.redhat.com/show_bug.cgi?id=1696423
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2019

Hammer backport details:

$ git log -1
commit 8b3ee76eaee27376c5f18ff3f7cc325b3cd23cc9
Author: Mike Turley <mike.turley@alum.cs.umass.edu>
Date:   Tue Jan 29 18:11:46 2019 -0500

    Merge pull request #864 from mzazrivec/add_empty_state_for_coversion_hosts
    
    Conversion Hosts: add initial button for empty state screen
    
    (cherry picked from commit eab39c449eceec38f621bc053ddf8642b0f8d2ab)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1696423

@mturley mturley mentioned this pull request Apr 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelkro michaelkro michaelkro approved these changes

@mturley mturley mturley approved these changes

Assignees
No one assigned
Labels
bz Issues filed by QE or having a BZ enhancement hammer/backported v1.2 z-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @simaishi @mturley @michaelkro