Conversion Host Configuration Wizard - Step #4 - Results (without passing SSH keys)

[mturley]

Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339

This is part of #855.

The initial version of this wizard step does not pass authentication credentials (SSH keys) to the API, since that backend support is still in development. A follow-up PR will be made to add that support and close out the rest of #855.

Screens

This step of the wizard generates a POST request to /api/conversion_hosts for each selected host or vm, displaying this loading state until all of those requests complete:

If there is an error returned from the API immediately (the task(s) could not even be queued), this error state is displayed in the wizard:

If the conversion host enablement task(s) are successfully queued, this message is displayed (using the same clock icon we use when a migration plan is started immediately at the end of the plan wizard):

Note that the queued task could still fail, but those errors will be reported in the list view, not in the wizard.

Implementation Details

Rather than duplicate the markup for the loading and error states a third time, I created new shared components WizardLoadingState and WizardErrorState to consolidate the existing code duplication, and used them in all three wizards. The special CSS that was used for the clock icon at the end of the plan wizard is now shared between two components, so I deleted the PlanWizardResultsStep.scss file and moved that CSS over to ModalWizard.scss with a more generic class name.

Polling for the task status will be handled outside the scope of this PR.

[miq-bot]

Checked commits mturley/manageiq-v2v@bca4cd3~...b89c402 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[apinnick]

The error message, "We're sorry, something went wrong. Please try again", sounds a bit lame. You might want to change it to something like "The conversion host cannot be configured. Please check your settings."

[mturley]

@apinnick I agree, I was actually copying that from the error message when creating migration plans and infrastructure mappings. I'll update those too, do you think I should use that same phrasing? ("The {migration plan / infrastructure mapping} could not be created. Please check your settings.")

Also, @vconzola has told me that we shouldn't say "Please" in the UI anyway. maybe that second sentence should just be "Check your settings and try again."

[apinnick]

@mturley I agree with @vconzola. We don't say "Please" or "Sorry". :-)
Your version is better.

[simaishi]

Hammer backport details:

$ git log -1
commit e328552343e8178a634cb36fbba15cbb04a01d92
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Mar 4 14:34:33 2019 +0100

    Merge pull request #883 from mturley/conv-host-wizard-step4
    
    Conversion Host Configuration Wizard - Step #4 - Results (without passing SSH keys)
    
    (cherry picked from commit 200c02265bb70421487574e81a92b70bb7c54615)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1696423