This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Conversion Host Settings page: Ensure task.meta will always be defined #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mturley@6d8a97d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Mar 14, 2019
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2019
Conversion Host Settings page: Ensure task.meta will always be defined (cherry picked from commit dc8eb8b) https://bugzilla.redhat.com/show_bug.cgi?id=1696423
|
Hammer backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339
This prevents an unlikely error that would occur if the task name field from the API is malformed. We parse it with a regular expression, and if the format of it changes in the future, that would cause console errors before when we filter on
task.meta.operation, and with this change a malformed task name will just cause that task to be filtered out.