Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Change layout of throttling settings form from horizontal to vertical #943

Merged

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Apr 18, 2019

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1701376

Originally part of feedback for #915, I merged that PR so we could make sure it ended up in Monday's build. This PR only changes the layout of the settings form.

Screenshot 2019-04-18 13 12 35

@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2019

Checked commits mturley/manageiq-v2v@28263ff~...fee3bee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Apr 23, 2019
@mzazrivec mzazrivec merged commit 5b85841 into ManageIQ:master Apr 23, 2019
@mturley mturley deleted the throttling-settings-vertical-layout branch April 23, 2019 13:28
@mturley mturley added bz Issues filed by QE or having a BZ and removed bugzilla needed labels Apr 23, 2019
@simaishi
Copy link
Contributor

@mturley Backport conflicts... can you please create a separate PR for hammer branch?

$ git status
On branch hammer
Your branch is up to date with 'origin/hammer'.

You are currently cherry-picking commit 5b858417.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   app/javascript/react/screens/App/Settings/Settings.scss
	modified:   app/javascript/react/screens/App/common/forms/TextInputWithCheckbox.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   app/javascript/react/screens/App/Settings/screens/GeneralSettings/GeneralSettings.js
	both modified:   app/javascript/react/screens/App/Settings/screens/GeneralSettings/__tests__/__snapshots__/GeneralSettings.test.js.snap

@mturley
Copy link
Contributor Author

mturley commented Apr 25, 2019

@simaishi here's the hammer-specific PR: #945

@simaishi
Copy link
Contributor

Backported to Hammer via #945

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants