Remove missing factory spec and all blank factories

Enhance FactoryGirl.create and FactoryGirl.build to super if the factory exists, otherwise call create or new directly. - No longer need to create an empty factory every time a new class is created - No longer need factories for things that shouldn't be factories (SchemaMigrations and join tables) - Many of the factories were incorrect to begin with (not inheriting from the base factory)
ManageIQ · Feb 9, 2018 · 1aebba0 · 1aebba0
1 parent 76b5084
commit 1aebba0
Show file tree

Hide file tree

Showing 218 changed files with 31 additions and 706 deletions.
diff --git a/spec/factories/advanced_setting.rb b/spec/factories/advanced_setting.rb
diff --git a/spec/factories/application_record.rb b/spec/factories/application_record.rb
diff --git a/spec/factories/asset_details.rb b/spec/factories/asset_details.rb
diff --git a/spec/factories/asset_tag_import.rb b/spec/factories/asset_tag_import.rb
diff --git a/spec/factories/audit_event.rb b/spec/factories/audit_event.rb
diff --git a/spec/factories/auth_private_key.rb b/spec/factories/auth_private_key.rb
diff --git a/spec/factories/auth_token.rb b/spec/factories/auth_token.rb
diff --git a/spec/factories/auth_userid_password.rb b/spec/factories/auth_userid_password.rb
diff --git a/spec/factories/authentication_configuration_script_base.rb b/spec/factories/authentication_configuration_script_base.rb
diff --git a/spec/factories/authentication_orchestration_stack.rb b/spec/factories/authentication_orchestration_stack.rb
diff --git a/spec/factories/authentication_rhsm.rb b/spec/factories/authentication_rhsm.rb
diff --git a/spec/factories/authenticator.rb b/spec/factories/authenticator.rb
diff --git a/spec/factories/binary_blob.rb b/spec/factories/binary_blob.rb
diff --git a/spec/factories/binary_blob_part.rb b/spec/factories/binary_blob_part.rb
diff --git a/spec/factories/bottleneck_event.rb b/spec/factories/bottleneck_event.rb
diff --git a/spec/factories/chargeback.rb b/spec/factories/chargeback.rb
diff --git a/spec/factories/chargeback_container_image.rb b/spec/factories/chargeback_container_image.rb
diff --git a/spec/factories/chargeback_container_project.rb b/spec/factories/chargeback_container_project.rb
diff --git a/spec/factories/chargeback_vm.rb b/spec/factories/chargeback_vm.rb
diff --git a/spec/factories/classification_import.rb b/spec/factories/classification_import.rb
diff --git a/spec/factories/cloud_database.rb b/spec/factories/cloud_database.rb
diff --git a/spec/factories/cloud_database_flavor.rb b/spec/factories/cloud_database_flavor.rb
diff --git a/spec/factories/cloud_object.rb b/spec/factories/cloud_object.rb
diff --git a/spec/factories/cloud_resource_quota.rb b/spec/factories/cloud_resource_quota.rb
diff --git a/spec/factories/cloud_subnet_network_port.rb b/spec/factories/cloud_subnet_network_port.rb
diff --git a/spec/factories/cloud_tenant_flavor.rb b/spec/factories/cloud_tenant_flavor.rb
diff --git a/spec/factories/compute_node.rb b/spec/factories/compute_node.rb
diff --git a/spec/factories/computer_system.rb b/spec/factories/computer_system.rb
diff --git a/spec/factories/condition_set.rb b/spec/factories/condition_set.rb
diff --git a/spec/factories/configuration_architecture.rb b/spec/factories/configuration_architecture.rb
diff --git a/spec/factories/configuration_compute_profile.rb b/spec/factories/configuration_compute_profile.rb
diff --git a/spec/factories/configuration_domain.rb b/spec/factories/configuration_domain.rb
diff --git a/spec/factories/configuration_environment.rb b/spec/factories/configuration_environment.rb
diff --git a/spec/factories/configuration_realm.rb b/spec/factories/configuration_realm.rb
diff --git a/spec/factories/configuration_tag.rb b/spec/factories/configuration_tag.rb
diff --git a/spec/factories/container_build.rb b/spec/factories/container_build.rb
diff --git a/spec/factories/container_build_pod.rb b/spec/factories/container_build_pod.rb
diff --git a/spec/factories/container_condition.rb b/spec/factories/container_condition.rb
diff --git a/spec/factories/container_deployment.rb b/spec/factories/container_deployment.rb
diff --git a/spec/factories/container_deployment_node.rb b/spec/factories/container_deployment_node.rb
diff --git a/spec/factories/container_env_var.rb b/spec/factories/container_env_var.rb
diff --git a/spec/factories/container_group_performance.rb b/spec/factories/container_group_performance.rb
diff --git a/spec/factories/container_groups_container_services.rb b/spec/factories/container_groups_container_services.rb
diff --git a/spec/factories/container_limit.rb b/spec/factories/container_limit.rb
diff --git a/spec/factories/container_limit_item.rb b/spec/factories/container_limit_item.rb
diff --git a/spec/factories/container_node_performance.rb b/spec/factories/container_node_performance.rb
diff --git a/spec/factories/container_performance.rb b/spec/factories/container_performance.rb
diff --git a/spec/factories/container_port_config.rb b/spec/factories/container_port_config.rb
diff --git a/spec/factories/container_project_performance.rb b/spec/factories/container_project_performance.rb
diff --git a/spec/factories/container_quota.rb b/spec/factories/container_quota.rb
diff --git a/spec/factories/container_quota_item.rb b/spec/factories/container_quota_item.rb
diff --git a/spec/factories/container_service_port_config.rb b/spec/factories/container_service_port_config.rb
diff --git a/spec/factories/container_template.rb b/spec/factories/container_template.rb
@@ -1,4 +1 @@
-FactoryGirl.define do
-  factory :container_template do
-  end
-end
+FactoryGirl.define { factory(:container_template) }
diff --git a/spec/factories/container_template_parameter.rb b/spec/factories/container_template_parameter.rb
diff --git a/spec/factories/container_volume_kubernetes.rb b/spec/factories/container_volume_kubernetes.rb
diff --git a/spec/factories/custom_event.rb b/spec/factories/custom_event.rb
diff --git a/spec/factories/customization_script.rb b/spec/factories/customization_script.rb
diff --git a/spec/factories/customization_script_medium.rb b/spec/factories/customization_script_medium.rb
diff --git a/spec/factories/customization_script_ptable.rb b/spec/factories/customization_script_ptable.rb
diff --git a/spec/factories/dialog_field_association.rb b/spec/factories/dialog_field_association.rb
diff --git a/spec/factories/dialog_field_association_validator.rb b/spec/factories/dialog_field_association_validator.rb
diff --git a/spec/factories/dialog_field_check_box.rb b/spec/factories/dialog_field_check_box.rb
diff --git a/spec/factories/dialog_field_date_control.rb b/spec/factories/dialog_field_date_control.rb
diff --git a/spec/factories/dialog_field_date_time_control.rb b/spec/factories/dialog_field_date_time_control.rb
diff --git a/spec/factories/dialog_field_importer.rb b/spec/factories/dialog_field_importer.rb
diff --git a/spec/factories/dialog_field_radio_button.rb b/spec/factories/dialog_field_radio_button.rb
diff --git a/spec/factories/dialog_field_serializer.rb b/spec/factories/dialog_field_serializer.rb
diff --git a/spec/factories/dialog_field_text_area_box.rb b/spec/factories/dialog_field_text_area_box.rb
diff --git a/spec/factories/dialog_group_serializer.rb b/spec/factories/dialog_group_serializer.rb
diff --git a/spec/factories/dialog_import_validator.rb b/spec/factories/dialog_import_validator.rb
diff --git a/spec/factories/dialog_serializer.rb b/spec/factories/dialog_serializer.rb
diff --git a/spec/factories/dialog_tab_serializer.rb b/spec/factories/dialog_tab_serializer.rb
diff --git a/spec/factories/dialog_yaml_serializer.rb b/spec/factories/dialog_yaml_serializer.rb
diff --git a/spec/factories/dictionary.rb b/spec/factories/dictionary.rb
diff --git a/spec/factories/disk.rb b/spec/factories/disk.rb
diff --git a/spec/factories/drift_state.rb b/spec/factories/drift_state.rb
diff --git a/spec/factories/dynamic_dialog_field_value_processor.rb b/spec/factories/dynamic_dialog_field_value_processor.rb
diff --git a/spec/factories/ems_cluster_performance.rb b/spec/factories/ems_cluster_performance.rb
diff --git a/spec/factories/ems_event.rb b/spec/factories/ems_event.rb
diff --git a/spec/factories/ems_refresh.rb b/spec/factories/ems_refresh.rb
diff --git a/spec/factories/event_log.rb b/spec/factories/event_log.rb
diff --git a/spec/factories/event_stream.rb b/spec/factories/event_stream.rb
diff --git a/spec/factories/ext_management_system_performance.rb b/spec/factories/ext_management_system_performance.rb
diff --git a/spec/factories/file_depot_ftp_anonymous.rb b/spec/factories/file_depot_ftp_anonymous.rb
diff --git a/spec/factories/file_depot_nfs.rb b/spec/factories/file_depot_nfs.rb
diff --git a/spec/factories/file_depot_smb.rb b/spec/factories/file_depot_smb.rb
diff --git a/spec/factories/firewall_rule.rb b/spec/factories/firewall_rule.rb
@@ -1,4 +1,3 @@
 FactoryGirl.define do
-  factory :firewall_rule do
-  end
+  factory :firewall_rule
 end
diff --git a/spec/factories/firmware.rb b/spec/factories/firmware.rb
diff --git a/spec/factories/guest_application.rb b/spec/factories/guest_application.rb
diff --git a/spec/factories/host_aggregate_host.rb b/spec/factories/host_aggregate_host.rb
diff --git a/spec/factories/host_metric.rb b/spec/factories/host_metric.rb
diff --git a/spec/factories/host_performance.rb b/spec/factories/host_performance.rb
diff --git a/spec/factories/host_storage.rb b/spec/factories/host_storage.rb
diff --git a/spec/factories/host_switch.rb b/spec/factories/host_switch.rb