Preferred defaulting opts to {} in method declaration, preferring fla…

…t_map over collect.flatten
ManageIQ · Mar 22, 2017 · 30ea361 · 30ea361
1 parent f7715b5
commit 30ea361
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/app/models/ext_management_system.rb b/app/models/ext_management_system.rb
@@ -400,8 +400,7 @@ def last_refresh_status
     end
   end
 
-  def refresh_ems(opts = nil)
-    opts ||= {}
+  def refresh_ems(opts = {})
     if missing_credentials?
       raise _("no %{table} credentials defined") % {:table => ui_lookup(:table => "ext_management_systems")}
     end

diff --git a/app/models/provider.rb b/app/models/provider.rb
@@ -54,14 +54,13 @@ def my_zone
   end
   alias_method :zone_name, :my_zone
 
-  def refresh_ems(opts = nil)
-    opts ||= {}
+  def refresh_ems(opts = {})
     if missing_credentials?
       raise _("no %{table} credentials defined") % {:table => ui_lookup(:table => "provider")}
     end
     unless authentication_status_ok?
       raise _("%{table} failed last authentication check") % {:table => ui_lookup(:table => "provider")}
     end
-    managers.collect { |manager| EmsRefresh.queue_refresh(manager, nil, opts) }.flatten
+    managers.flat_map { |manager| EmsRefresh.queue_refresh(manager, nil, opts) }
   end
 end