We shouldn't retire load balancers

ManageIQ · Feb 11, 2019 · 4940668 · 4940668
1 parent 6f5a1b0
commit 4940668
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/app/models/load_balancer.rb b/app/models/load_balancer.rb
@@ -2,7 +2,6 @@ class LoadBalancer < ApplicationRecord
   include NewWithTypeStiMixin
   include AsyncDeleteMixin
   include ProcessTasksMixin
-  include RetirementMixin
   include TenantIdentityMixin
   include CloudTenancyMixin
   include CustomActionsMixin

diff --git a/app/models/retirement_manager.rb b/app/models/retirement_manager.rb
@@ -1,7 +1,7 @@
 class RetirementManager
   def self.check
     ems_ids = MiqServer.my_server.zone.ext_management_system_ids
-    [LoadBalancer, OrchestrationStack, Vm, Service].flat_map do |i|
+    [OrchestrationStack, Vm, Service].flat_map do |i|
       instances = not_retired_with_ems(i, ems_ids)
       instances.each(&:retirement_check)
     end

diff --git a/spec/models/retirement_manager_spec.rb b/spec/models/retirement_manager_spec.rb
@@ -4,16 +4,14 @@
       _, _, zone = EvmSpecHelper.local_guid_miq_server_zone
       ems = FactoryBot.create(:ems_network, :zone => zone)
 
-      load_balancer = FactoryBot.create(:load_balancer, :retires_on => Time.zone.today + 1.day, :ext_management_system => ems)
-      FactoryBot.create(:load_balancer, :retired => true)
       orchestration_stack = FactoryBot.create(:orchestration_stack, :retires_on => Time.zone.today + 1.day, :ext_management_system => ems)
       FactoryBot.create(:orchestration_stack, :retired => true)
       vm = FactoryBot.create(:vm, :retires_on => Time.zone.today + 1.day, :ems_id => ems.id)
       FactoryBot.create(:vm, :retired => true)
       service = FactoryBot.create(:service, :retires_on => Time.zone.today + 1.day)
       FactoryBot.create(:service, :retired => true)
 
-      expect(RetirementManager.check).to match_array([load_balancer, orchestration_stack, vm, service])
+      expect(RetirementManager.check).to match_array([orchestration_stack, vm, service])
     end
   end
 end