InventoryCollection's Builder exception message

Adds message with suggestion of model_class.
ManageIQ · Aug 27, 2018 · 7ebe34e · 7ebe34e
1 parent 01044b9
commit 7ebe34e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/models/manageiq/providers/inventory/persister/builder.rb b/app/models/manageiq/providers/inventory/persister/builder.rb
@@ -80,7 +80,7 @@ def construct_data
       # Creates InventoryCollection
       def to_inventory_collection
         if @properties[:model_class].nil? && !@options[:without_model_class]
-          raise MissingModelClassError
+          raise MissingModelClassError, "Missing model_class for :#{@name} (\"#{@name.to_s.classify}\" or subclass expected)."
         end
 
         ::ManagerRefresh::InventoryCollection.new(to_hash)

diff --git a/spec/models/manageiq/providers/inventory/persister/builder_spec.rb b/spec/models/manageiq/providers/inventory/persister/builder_spec.rb
@@ -58,7 +58,7 @@ def create_persister
   it 'throws exception if model_class not specified' do
     builder = cloud.prepare_data(:non_existing_ic, persister_class)
 
-    expect { builder.to_inventory_collection }.to raise_error(::ManageIQ::Providers::Inventory::Persister::Builder::MissingModelClassError)
+    expect { builder.to_inventory_collection }.to raise_error(::ManagerRefresh::InventoryCollection::Builder::MissingModelClassError, /NonExistingIc/)
   end
 
   # --- adv. settings (TODO: link to gui)---