Merge pull request #19254 from yrudman/do-not-calculate-backlog-when-…

…subscription-not-active

[HAMMER]Do not calculate backlog when subscription not active

app/models/pglogical_subscription.rb

@@ -108,10 +108,16 @@ def validate(new_connection_params = {})
  end
 
  def backlog
- connection.xlog_location_diff(remote_node_lsn, remote_replication_lsn)
- rescue PG::Error => e
- _log.error(e.message)
- nil
+ if status != "replicating"
+ _log.error("Is `#{dbname}` running on host `#{host}` and accepting TCP/IP connections on port #{port} ?")
+ return nil
+ end
+ begin
+ connection.xlog_location_diff(remote_node_lsn, remote_replication_lsn)
+ rescue PG::Error => e
+ _log.error(e.message)
+ nil
+ end
  end
 
  # translate the output from the pglogical stored proc to our object columns

spec/models/pglogical_subscription_spec.rb

@@ -496,5 +496,12 @@
 
  expect(described_class.first.backlog).to be nil
  end
+
+ it 'does not attempt to calculate backlog and returns nil unless subscription status is "replicating"' do
+ allow(described_class).to receive(:status).and_return("down")
+
+ expect(remote_connection).not_to receive(:xlog_location)
+ expect(described_class.first.backlog).to be nil
+ end
  end
 end