Skip to content

Commit

Permalink
Fixes tests
Browse files Browse the repository at this point in the history
  • Loading branch information
d-m-u committed Jan 8, 2018
1 parent 7b80b5b commit b8e33d0
Showing 1 changed file with 14 additions and 16 deletions.
30 changes: 14 additions & 16 deletions spec/models/customization_template_spec.rb
Original file line number Diff line number Diff line change
@@ -1,42 +1,40 @@
describe CustomizationTemplate do
context "#name" do
before do
FactoryGirl.create(:customization_template, :name => "template")
FactoryGirl.create(:customization_template_cloud_init, :name => "template1")
end

context "two pxe templates" do
it "raises error with non-unique names" do
expect { FactoryGirl.create(:customization_template, :name => "foo") }.to_not raise_error
expect { FactoryGirl.create(:customization_template, :name => "foo") }
.to raise_error(ActiveRecord::RecordInvalid, /Name has already been taken/)
expect { FactoryGirl.create(:customization_template, :name => "template") }
.to raise_error(ActiveRecord::RecordInvalid, / Name is not unique within region/)
end

it "doesn't raise error with unique names" do
expect { FactoryGirl.create(:customization_template, :name => "foo") }.to_not raise_error
expect { FactoryGirl.create(:customization_template, :name => "something else", :pxe_image_type => PxeImageType.new(:name => "image1")) }.to_not raise_error
expect { FactoryGirl.create(:customization_template) }.to_not raise_error
end
end

context "pxe template and a non pxe template" do
it "raises error with non-unique names" do
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "foo") }.to_not raise_error
expect { FactoryGirl.create(:customization_template, :name => "foo", :system => true, :pxe_image_type => nil) }
.to raise_error(ActiveRecord::RecordInvalid, /Name has already been taken/)
expect { FactoryGirl.create(:customization_template, :name => "template1") }
.to raise_error(ActiveRecord::RecordInvalid, / Name is not unique within region/)
end

it "doesn't raise error with unique names" do
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "foo", :system => true, :pxe_image_type => nil) }.to_not raise_error
expect { FactoryGirl.create(:customization_template, :name => "something else", :pxe_image_type => PxeImageType.new(:name => "image1")) }
.to_not raise_error
expect { FactoryGirl.create(:customization_template) }.to_not raise_error
end
end

context "two non pxe templates" do
it "raises error with non-unique names" do
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "foo", :system => true) }.to_not raise_error
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "foo", :system => true) }
.to raise_error(ActiveRecord::RecordInvalid, /Name has already been taken/)
expect { FactoryGirl.create(:customization_template_sysprep, :name => "template1") }
.to raise_error(ActiveRecord::RecordInvalid, / Name is not unique within region/)
end

it "doesn't raise error with unique names" do
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "foo", :system => true, :pxe_image_type => PxeImageType.new(:name => "image1")) }.to_not raise_error
expect { FactoryGirl.create(:customization_template_cloud_init, :name => "other", :system => true, :pxe_image_type => PxeImageType.new(:name => "image2")) }.to_not raise_error
expect { FactoryGirl.create(:customization_template_sysprep) }.to_not raise_error
end
end
end
Expand Down

0 comments on commit b8e33d0

Please sign in to comment.