adding hostname format validation

ManageIQ · Dec 22, 2017 · ba0b230 · ba0b230
1 parent 2d95d40
commit ba0b230
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/app/models/ext_management_system.rb b/app/models/ext_management_system.rb
@@ -76,7 +76,7 @@ def self.supported_types_and_descriptions_hash
 
   validates :name,     :presence => true, :uniqueness => {:scope => [:tenant_id]}
   validates :hostname, :presence => true, :if => :hostname_required?
-  validate :hostname_uniqueness_valid?, :if => :hostname_required?
+  validate :hostname_uniqueness_valid?, :hostname_format_valid?, :if => :hostname_required?
 
   scope :with_eligible_manager_types, ->(eligible_types) { where(:type => eligible_types) }
 
@@ -92,6 +92,12 @@ def hostname_uniqueness_valid?
     errors.add(:hostname, N_("has to be unique per provider type")) if existing_hostnames.include?(hostname.downcase)
   end
 
+  def hostname_format_valid?
+    return if hostname.ipaddress? || hostname.hostname?
+    error_msg = N_("is in a wrong format.")
+    errors.add(:hostname, _(error_msg))
+  end
+
   include NewWithTypeStiMixin
   include UuidMixin
   include EmsRefresh::Manager