Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiqServer.check_migrations_up_to_date method always logs warning message caused by comparison error #16670

Closed
gmcculloug opened this issue Dec 14, 2017 · 1 comment
Closed

MiqServer.check_migrations_up_to_date method always logs warning message caused by comparison error #16670

gmcculloug opened this issue Dec 14, 2017 · 1 comment
Assignees
@bdunne
Labels
bug sql migration

Comments

@gmcculloug
Copy link
Member

The method file_migration_list in the SchemaMigration model is referencing the schema files in the old location. The files have all moved to ManageIQ/manageiq-schema.

This causes initial_migration to return nil and missing_file_migrations to raise an error resulting in the follow warn message in the logs:

[----] W, [2017-12-14T16:01:24.073145 #6812:3ff30c83f7cc] WARN -- : MIQ(MiqServer.check_migrations_up_to_date) comparison of Integer with nil failed

@bdunne Please reassign if needed
@gmcculloug gmcculloug changed the title MiqServer.check_migrations_up_to_date method always logs warning message based on comparison error MiqServer.check_migrations_up_to_date method always logs warning message caused by comparison error Dec 14, 2017
@Fryguy
Copy link
Member

Fryguy commented Jan 3, 2018

@bdunne Should the SchemaMigration model just move to the schema repo anyway?

@bdunne bdunne mentioned this issue Feb 28, 2018
Merged
bdunne added a commit to bdunne/manageiq that referenced this issue Feb 28, 2018
@bdunne
Move SchemaMigration from ManageIQ to ManageIQ::Schema plugin
f14960f 
Fixes ManageIQ#16670
@bdunne bdunne mentioned this issue Feb 28, 2018
Merged
JakubKubista pushed a commit to JakubKubista/manageiq that referenced this issue Apr 12, 2018
@bdunne
Move SchemaMigration from ManageIQ to ManageIQ::Schema plugin
66d9cf0 
Fixes ManageIQ#16670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdunne bdunne

Labels
bug sql migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fryguy @bdunne @gmcculloug