Enable config.load_defaults in rails application.rb and determine which defaults we need to modify #23172

jrafanie · 2024-09-03T20:43:38Z

We currently disable loading defaults for one known reason, belongs_to_required_by_default. It's hard to know or remember if there are others we need to change from the defaults. We should try to enable defaults and manually undo specific defaults we still need the old behavior.

As of right now, it's hard to tell what changes we have from the defaults. At least if we enumerate our needed changes, we can try to fix each one separately and move our application closer to the defaults.

EDIT: Note, rails documents the defaults for each version here: https://guides.rubyonrails.org/configuring.html#versioned-default-values

Fryguy · 2024-09-03T20:45:54Z

FWIW, when I changed the manageiq-schema dummy app to Rails 7.0, this was one of the ones I kept in place:

You can see how we load the defaults, and then change 2 settings here: https://github.com/ManageIQ/manageiq-schema/blob/688930bd09ae0c39a91edc8a6770d41234563749/spec/dummy/config/application.rb

As far as I can see, belongs_to_required_by_default, is the only override in load_defaults that we manually override. See: https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L92 This change makes the override explicit. Fixes ManageIQ#23172

https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L92 * belongs_to_required_by_default must be overridden or seeding fails * Partial inserts cause test failures in ui-classic, content, and amazon provider * Need to investigate the X-XSS-Protection change before using default of disabling it * Allow deprecations to be found and fixed Fixes ManageIQ#23172

jrafanie added the enhancement label Sep 3, 2024

jrafanie self-assigned this Sep 3, 2024

jrafanie added the technical debt label Sep 3, 2024

jrafanie linked a pull request Sep 5, 2024 that will close this issue

Use config.load_defaults for rails 7 with overrides #23176

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable config.load_defaults in rails application.rb and determine which defaults we need to modify #23172

Enable config.load_defaults in rails application.rb and determine which defaults we need to modify #23172

jrafanie commented Sep 3, 2024 •

edited

Loading

Fryguy commented Sep 3, 2024

Enable config.load_defaults in rails application.rb and determine which defaults we need to modify #23172

Enable config.load_defaults in rails application.rb and determine which defaults we need to modify #23172

Comments

jrafanie commented Sep 3, 2024 • edited Loading

Fryguy commented Sep 3, 2024

jrafanie commented Sep 3, 2024 •

edited

Loading