Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualDelegate: Fix foreign key for belongs_to #10717

Merged
merged 6 commits into from
Sep 9, 2016
Merged

VirtualDelegate: Fix foreign key for belongs_to #10717

merged 6 commits into from
Sep 9, 2016

Commits on Sep 2, 2016

  1. Ensure virtual attributes don't reuse table alias 

    before:
if this table is part of the primary query, then the table alias will
conflict.

after:
use a different table alias so it does not conflict.
    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    dc8e1a3 View commit details
    Browse the repository at this point in the history

  2. proper foreign_key for delegates

    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    f094326 View commit details
    Browse the repository at this point in the history

  3. Tests for ar_virtual belongs_to delegation

    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    ebb65a7 View commit details
    Browse the repository at this point in the history

  4. ensure subclass uses correct db connection 

    the db connection is non standard, and establish_connection is not
properly inheriting the connection from the parent but rather the
default (postgres)

only really shows up once we use has_one tests
    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    e6c27fc View commit details
    Browse the repository at this point in the history

  5. Tests for ar_virtual has_one delegation 

    this also tests the has_one with self reference
    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    c6a3ab6 View commit details
    Browse the repository at this point in the history

  6. document select_from_alias

    @kbrock
    kbrock committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    519a63b View commit details
    Browse the repository at this point in the history