Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar button refactoring server role #11715

Merged
merged 19 commits into from
Nov 2, 2016
Merged

Toolbar button refactoring server role #11715

merged 19 commits into from
Nov 2, 2016

Commits on Nov 2, 2016

  1. Removed unused toolbar button server_delete

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    86cc443 View commit details
    Browse the repository at this point in the history

  2. Created generic class for role power options toolbar buttons

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    ebe3853 View commit details
    Browse the repository at this point in the history

  3. Toolbar button role_start moved to separate class

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    d23141c View commit details
    Browse the repository at this point in the history

  4. Toolbar button role_suspend moved to separate class

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    2191096 View commit details
    Browse the repository at this point in the history

  5. Toolbar buttons zone_role_start and zone_role_suspend moved to separa… 

    …te class
    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    b1e8bb3 View commit details
    Browse the repository at this point in the history

  6. Created generic class for server level options toolbar buttons

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    d1e9be4 View commit details
    Browse the repository at this point in the history

  7. Toolbar buttons zone_demote_server and zone_promote_server moved to s… 

    …eparate class
    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    a330105 View commit details
    Browse the repository at this point in the history

  8. Toolbar button promote_server moved to separate class

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    e6e3c5e View commit details
    Browse the repository at this point in the history

  9. Toolbar button demote_server moved to separate class

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    9a4b04d View commit details
    Browse the repository at this point in the history

  10. Removed specs for converted buttons

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    4b38078 View commit details
    Browse the repository at this point in the history

  11. Added spec for role_start toolbar button

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    dea8d40 View commit details
    Browse the repository at this point in the history

  12. Added spec for role_suspend toolbar button

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    4a07ca0 View commit details
    Browse the repository at this point in the history

  13. Added spec for server_demote toolbar button

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    c8ad064 View commit details
    Browse the repository at this point in the history

  14. Added spec for server_promote toolbar button

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    cd5b186 View commit details
    Browse the repository at this point in the history

  15. Updated generic classes, to check if the tree is correct

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    e3d44ee View commit details
    Browse the repository at this point in the history

  16. Updated specs

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    397832d View commit details
    Browse the repository at this point in the history

  17. Review response: Added missing instance variable 

    `@sb` variable is not called directly in the button class, but needs to be set, because
`x_active_tree` and `x_node` are wrappers for the `@sb`.
    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    c22f642 View commit details
    Browse the repository at this point in the history

  18. Use view context for ApplicationHelper methods

    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    93627f2 View commit details
    Browse the repository at this point in the history

  19. Making sure that converted buttons do not get hidden by toolbar_build… 

    …er methods

Buttons in 'diagnostics_servers_roles' and 'diagnostics_roles_servers'
that were converted to separate classes were still getting hide,
because in `toolbar_builder.rb` the method `build_toolbar_hide_button_ops`
returns `true` for the buttons that are not listed in the case.

By setting `false` and listing the buttons that are not converted yet
in the case switch, the converted buttons are getting displayed correctly.
    @romanblanco
    romanblanco committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    eadc3fc View commit details
    Browse the repository at this point in the history