Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings for CB calculation&report are worth to be represented by separate class #12049

Merged
merged 13 commits into from
Oct 24, 2016
Merged

Settings for CB calculation&report are worth to be represented by separate class #12049

merged 13 commits into from
Oct 24, 2016

Commits on Oct 24, 2016

  1. Set @options only once 

    There are three possible callers of build_results_for_report_chargeback
each of them sets @options to the same value that is later passed in as
an argument.

Let's have a single place to set it.

In future I want to get a rid of class variable. But it will take few
moments before we get there.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    52a00de View commit details
    Browse the repository at this point in the history

  2. Drop support from start_time and end_time options 

    This was used for Ad-hoc chargeback schedule. It is unused since 2010
(a59b87cf535fd464d56d145bac12873cff65ea7d).
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    60554db View commit details
    Browse the repository at this point in the history

  3. Drop chargeback_type option documentation 

    This was never actual option. Only a design idea that never come to be
implemented. Let's drop this from documentation now, so we can
consolidate the options more.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    2c83677 View commit details
    Browse the repository at this point in the history

  4. Use Struct for storing Chargeback calculation options 

    This will allow us to encapsulate code manipulating it here.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    2b7e9f4 View commit details
    Browse the repository at this point in the history

  5. Refactor: Extract method: tz 

    Timezone depends solely on Chargeback/ReportOptions.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    7e72957 View commit details
    Browse the repository at this point in the history

  6. Default interval should be property of ReportOptions

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    e0ecace View commit details
    Browse the repository at this point in the history

  7. Refactor: move and rename method: report_time_range 

    The chargeback's timerange depends only on Chargeback report options.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    f5df793 View commit details
    Browse the repository at this point in the history

  8. Refactor: move and rename method: duration_of_report_step 

    It is only dependent on ReportOptions and shall be part of it.
    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    edb6431 View commit details
    Browse the repository at this point in the history

  9. Do not pass interval variable along, use @options

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    9cb4026 View commit details
    Browse the repository at this point in the history

  10. Refactor: Extract method: start_of_report_step

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    059c92a View commit details
    Browse the repository at this point in the history

  11. Refactor: Extract method: tag_hash

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    473d14c View commit details
    Browse the repository at this point in the history

  12. Refactor: Extract method: report_step_range

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    814718d View commit details
    Browse the repository at this point in the history

  13. Set default :ext_options in Chargeback::ReportOptions

    @isimluk
    isimluk committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    f068bd8 View commit details
    Browse the repository at this point in the history