ChargebackRateDetail should take care of charging #12616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
As it better describes what it does. It calculates hourly cost for a given metric.
isimluk
force-pushed
the
only-rate-should-know-what-to-charge
branch
2 times, most recently
from
36967a7
to
8cde768
Compare
gtanzillo
approved these changes
Nov 18, 2016
| @@ -210,6 +210,17 @@ def contiguous_tiers? | |||
| !error | |||
| end | |||
|
|
|||
| def affects_metrics | |||
There was a problem hiding this comment.
I'm not sure about the naming of these methods. How about metrics_keys and cost_keys?
This will be needed once we will have ChargebackRateDetails with dynamic rate/metric names.
Not all the rates are relevant to the given chargeback. At this moment, the field is calculated only if the given chargeback type is able to carry on the result. In future, we may be able to calculate only those fields/columns needed by user. Then this method will come in handy. Using word fields vs. columns as it is common more common in the chargeback's codebase now.
isimluk
force-pushed
the
only-rate-should-know-what-to-charge
branch
from
8cde768
to
4588c62
Compare
|
Amended the method name as advised. |
|
Checked commits isimluk/manageiq@16d00c3~...4588c62 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/chargeback.rb
|
|
Backported to Euwe via #13419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the charging responsibility from chargeback downto chargeback_rate_detail.
This series of refactorings are the ground works for dynamic charging (needed to charge differently per different storage types). Once we have this, the rate_detail can charge per dynamic field i.e. storate_allocated_ssd_cost, storage_allocated_hiperf_cost (that is related to #12501).
@miq-bot add_label chargeback, refactoring
@miq-bot assign @gtanzillo