Simplify tag list reconstruct #12670
Conversation
lpichler
force-pushed
the
simplify_tag_list_reconstruct
branch
2 times, most recently
from
33aa471
to
8629121
Compare
| @@ -21,11 +21,11 @@ def tag_prefix | |||
| def tag_list_reconstruct | |||
| tag_list = tag_names | |||
|
|
|||
| if resource_type == Container.name | |||
| if resource.instance_of?(Container) | |||
There was a problem hiding this comment.
I think this may lead to extra Select query.
Although, this is minor nitpick and can be ignored.
There was a problem hiding this comment.
I am not sure about it I thought that resource is preloaded in by include base_rollup query, isn't ?
https://github.com/ManageIQ/manageiq/blob/master/app/models/chargeback.rb#L26
| if resource.instance_of?(Container) | ||
| state = resource.vim_performance_state_for_ts(timestamp.to_s) | ||
| tag_list += state.image_tag_names if state.present? | ||
| image_tag_name = "#{state.try(:image_tag_name)}|" if state |
There was a problem hiding this comment.
I think either that if or that try is enough. I think, there is no need to have both.
This is however minor nitpick and can be ignored.
There was a problem hiding this comment.
yes, I think we also avoid to use try because then you can easily overlook that there is typo
|
👍 Thanks! |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
Rates cache is now in. We can rebase and unwip. 🍔 |
and add here also TAG_MANAGED_PREFIX and move /tag/managed/ to constant
lpichler
force-pushed
the
simplify_tag_list_reconstruct
branch
from
8629121
to
48363fb
Compare
lpichler
force-pushed
the
simplify_tag_list_reconstruct
branch
from
48363fb
to
70bd693
Compare
|
Checked commits lpichler/manageiq@2009cc4~...70bd693 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@miq-bot remove_label wip |
lpichler
changed the title
|
👍 LGTM |
|
Backported to Euwe via #13419 |
continuing of #12608 (created on top of this PR - reason for WIP)
🎁 @isimluk
@miq-bot add_label wip
@miq-bot add_label chargeback, refactoring