use delegate for cpu_total_cores / cpu_cores_per_socket #12911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit kbrock@be31c85 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
NickLaMuro
reviewed
Nov 30, 2016
| @@ -157,8 +157,7 @@ class VmOrTemplate < ApplicationRecord | |||
| virtual_column :num_hard_disks, :type => :integer, :uses => {:hardware => :hard_disks} | |||
| virtual_column :num_disks, :type => :integer, :uses => {:hardware => :disks} | |||
| virtual_column :num_cpu, :type => :integer, :uses => :hardware | |||
| virtual_column :cpu_total_cores, :type => :integer, :uses => :hardware | |||
| virtual_column :cpu_cores_per_socket, :type => :integer, :uses => :hardware | |||
| virtual_delegate :cpu_total_cores, :cpu_cores_per_socket, :to => :hardware, :allow_nil => true, :default => 0 | |||
There was a problem hiding this comment.
Darga currently doesn't have #10476, which would allow for adding the :default option that you have here.
There was a problem hiding this comment.
thanks - removed from darga
|
👍 LGTM |
simaishi
pushed a commit
that referenced
this pull request
Mar 2, 2017
use delegate for cpu_total_cores / cpu_cores_per_socket (cherry picked from commit 91517e8) https://bugzilla.redhat.com/show_bug.cgi?id=1422647
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to calculate columns like
aggressive_vcpus_recommended_change_pctin the database.These columns are calculated from
cpu_total_coresamong others.Using a delegate here will define the arel for us so it can be a virtual attribute with sql.
(The final solution still requires all the other columns be converted to arel as well...)
related to #12733
https://bugzilla.redhat.com/show_bug.cgi?id=1395743
/cc @NickLaMuro FYI