-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selection of a node in Snapshot tree #12980
Conversation
8c57580
to
d5f90da
Compare
@miq-bot remove_label wip |
@miq-bot add_label blocker |
65335ee
to
11cfa6d
Compare
@ZitaNemeckova i still see same issue on snapshots tree screen, on initial load of screen, a non-active snapshot is selected and Create a new Snapshot button is enabled, see the attached screenshot. Second issue is still there where the node with Active snapshot is not getting expanded, clicking on the arrow doesn't load children under that node. |
Save info about VmOrTemplate of Snapshot tree. Add :highlighted to selected node.
11cfa6d
to
e8d7043
Compare
@h-kataria First issue solved. Second should be resolved by #12986. I checked and it works for me. Thanks for review :) |
af2b1bb
to
0e8df4c
Compare
@ZitaNemeckova there's a relevant spec failure, please take a look. |
I'm adding a wip label, until the CI failure is resolved. |
0e8df4c
to
7ee75d7
Compare
7ee75d7
to
406bae0
Compare
Checked commits ZitaNemeckova/manageiq@218fa2f~...406bae0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
@miq-bot remove_label wip |
retested, verified fix. |
Fix selection of a node in Snapshot tree (cherry picked from commit a495372) https://bugzilla.redhat.com/show_bug.cgi?id=1402991
Euwe Backport details: $ git log -1
commit 18fdbd6d3447d420e02d4da1d6f7c37f75242a43
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Thu Dec 8 11:35:38 2016 -0500
Merge pull request #12980 from ZitaNemeckova/snapshot_fix
Fix selection of a node in Snapshot tree
(cherry picked from commit a49537249c11edeb3c9a606a36da6d96c72b65ba)
https://bugzilla.redhat.com/show_bug.cgi?id=1402991 |
https://bugzilla.redhat.com/show_bug.cgi?id=1398239
Before:
node is not selected at init
After:
node is selected at init
@miq-bot add_label wip, ui, bug, euwe/yes