Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection of a node in Snapshot tree #12980

Merged
merged 3 commits into from
Dec 8, 2016

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Dec 5, 2016

https://bugzilla.redhat.com/show_bug.cgi?id=1398239

Before:
node is not selected at init

After:
node is selected at init

@miq-bot add_label wip, ui, bug, euwe/yes

@ZitaNemeckova ZitaNemeckova changed the title [WIP] Fix selection of a node in Snapshot tree Fix selection of a node in Snapshot tree Dec 6, 2016
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Dec 6, 2016
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label blocker

@h-kataria
Copy link
Contributor

@ZitaNemeckova i still see same issue on snapshots tree screen, on initial load of screen, a non-active snapshot is selected and Create a new Snapshot button is enabled, see the attached screenshot. Second issue is still there where the node with Active snapshot is not getting expanded, clicking on the arrow doesn't load children under that node.
snapshots tree after the fix:
snapshots_tree

Save info about VmOrTemplate of Snapshot tree. Add :highlighted to selected node.
@ZitaNemeckova
Copy link
Contributor Author

@h-kataria First issue solved. Second should be resolved by #12986. I checked and it works for me. Thanks for review :)

@ZitaNemeckova ZitaNemeckova force-pushed the snapshot_fix branch 2 times, most recently from af2b1bb to 0e8df4c Compare December 7, 2016 13:25
@dclarizio
Copy link

@ZitaNemeckova there's a relevant spec failure, please take a look.

@mzazrivec mzazrivec added the wip label Dec 7, 2016
@mzazrivec
Copy link
Contributor

I'm adding a wip label, until the CI failure is resolved.

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2016

Checked commits ZitaNemeckova/manageiq@218fa2f~...406bae0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 0 offenses detected
Everything looks good. 🏆

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Dec 8, 2016
@h-kataria
Copy link
Contributor

retested, verified fix.

@dclarizio dclarizio merged commit a495372 into ManageIQ:master Dec 8, 2016
@dclarizio dclarizio added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 8, 2016
@chessbyte
Copy link
Member

chessbyte pushed a commit that referenced this pull request Dec 8, 2016
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit 18fdbd6d3447d420e02d4da1d6f7c37f75242a43
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Dec 8 11:35:38 2016 -0500

    Merge pull request #12980 from ZitaNemeckova/snapshot_fix
    
    Fix selection of a node in Snapshot tree
    (cherry picked from commit a49537249c11edeb3c9a606a36da6d96c72b65ba)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1402991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants