remove outdated css / update expression editor toolbar styling #12998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label ui, technical debt |
|
@miq-bot assign @dclarizio |
mzazrivec
reviewed
Dec 6, 2016
| .searchtoolbar li img.dimmed { background: none;} | ||
|
|
||
| /* Automate Specific */ | ||
| .checkall { padding: 0 0 7px 7px;} /*styling for automate (Check All) */ |
There was a problem hiding this comment.
Isn't the checkall class still being used by automate hamls? Is see that class in
app/views/miq_ae_class/_class_instances.html.haml
app/views/miq_ae_class/_class_methods.html.haml
app/views/miq_ae_class/_ns_details.html.haml
app/views/miq_ae_class/_ns_list.html.haml
There was a problem hiding this comment.
@mzazrivec It looks like it is used by the JS. I tested those screens, the styling isn't needed.
There was a problem hiding this comment.
@epwinchell I see, never mind then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/1613907/stories/129462395
Old
New