Adding new report and widgets #13055

nimrodshn · 2016-12-08T14:14:29Z

I have added a new report and a new widget as per request of a client.
It is the first widget in a series of widgets suggested by this client in order to support our existing and new container reports.

cc: @simon3z @zeari

Additional Reports:

Projects by Number of Containers
Pods per Ready Status

Additional Widgets:

miq-bot · 2016-12-08T14:23:07Z

@nimrodshn Cannot apply the following label because they are not recognized: widgets

zeari · 2016-12-08T14:54:32Z

@miq-bot add_label providers/containers

zeari · 2016-12-08T14:56:07Z

@nimrodshn Please verify all the widgets youre adding show correct data and have screenshots of them on this PR.

Edit: Careful when exporting them out of miq since those usually have attributes like user_id\group_id that are specific to the miq instance that exported them.

simon3z · 2016-12-12T10:05:21Z

@nimrodshn I understand this is a WIP, but there were more widgets to add right?

nimrodshn · 2016-12-12T10:13:11Z

@simon3z yes there are eleven more, I am uploading them carefully one-by-one for three reason:

As @zeari said they contain information which is irrelevant.
Making sure they are working and producing informative results.
The yml the customer produced has six of those widgets combined - thinking ahead - it does not mean every user will want all of those widgets, maybe just some of them.
It basically comes down to nitpicking in his yml.

nimrodshn · 2016-12-28T09:39:43Z

Added three more widgets as shown in the following screenshot (the three top widgets):

nimrodshn · 2016-12-29T13:42:32Z

Added three more widgets as noted in the following (top three widgets):

simon3z · 2017-01-02T16:12:43Z

.../reports/170_Configuration Management - Containers/120_Projects by Number of Containers.yaml

@@ -0,0 +1,44 @@
+---
+title: Projects by Number of Containers


@nimrodshn please convert this (no CRLF).

simon3z · 2017-01-02T16:13:24Z

@nimrodshn anything still missing here? When we'll be able to remove the "WIP"?

nimrodshn · 2017-01-02T16:38:24Z

Six more missing .. (as noted by the checklist above.)

nimrodshn · 2017-01-04T11:13:42Z

Added the rest of widgets needed. @simon3z

simon3z · 2017-01-20T10:31:28Z

@nimrodshn have you tested all of these?
Once we merge these and release to customers there's little that we can do to update/fix them so they have to be fully correct.

yaacov · 2017-01-20T11:02:08Z

Number of Nodes per Cpu Cores Widget

a. do we need to remind the user it's a widget in the title ... Cores Widget ?
b. the table show nodes per cpu core and not number of nodes per cpu core ?

Number of Nodes per Cpu Cores Chart

a. i can see it is a chart ...
b. how useful is this (*) , maybe we should show number of cores per node ?

(*) does it help me to know that i have two machines running 4 cores and one machine running 2 cores ( i do not have information about the cores, and if one core is the same as the other, one can be arm7 and the next a xeon )

nimrodshn · 2017-01-25T08:42:35Z

@yaacov all of your remarks are valid.

I just want to be clear - these are widgets that we have received from a client, all I did was to bring them in, clean them and debug them. If I change anything like you have suggested they will not be the same as the ones the client had asked.

Maybe @simon3z can weigh in on these questions?

simon3z · 2017-01-25T09:09:11Z

Number of Nodes per Cpu Cores Widget

a. do we need to remind the user it's a widget in the title ... Cores Widget ?

No, it's already in the widget section. Please remove "Widget" from all.

b. the table show nodes per cpu core and not number of nodes per cpu core ?

Actually I don't see any grouping here. I just see a list of nodes with their core numbers.
I don't think this was the intent of the report.

Number of Nodes per Cpu Cores Chart

b. how useful is this (*) , maybe we should show number of cores per node ?

This seems OK as use-case, also you can't display all nodes here (what if you have 300 nodes, why would I care to only display some, and anyway it's impossible to show them all).

nimrodshn · 2017-01-25T09:11:50Z

@simon3z As for you're second comment do you think I should remove 'Number of Nodes per CPU' widget altogether?

simon3z · 2017-01-25T09:14:44Z

@simon3z As for you're second comment do you think I should remove 'Number of Nodes per CPU' widget altogether?

@nimrodshn send an email to the author and find out what he intended there (cc our mailing list as well).

nimrodshn · 2017-01-26T08:34:28Z

The author of the widgets have agreed to change the title of that widget, also he had reviewed them and said they look good to him -

FYI @simon3z @yaacov

simon3z · 2017-01-26T08:35:57Z

The author of the widgets have agreed to change the title of that widget, also he had reviewed them and said they look good to him -

@nimrodshn OK but still the name doesn't seem to match the content.

@nimrodshn please squash the patches in one and update the screenshot (if you still have all the data and it's easy, etc.)

nimrodshn · 2017-01-26T09:32:09Z

@simon3z Ah! You are of course correct! - How about this title?

nimrodshn · 2017-01-26T10:28:01Z

After conversing with @simon3z we have decided to remove 'Nodes By CPU Cores' since It was not informative and we already have a histogram of it.
FYI @yaacov

Added new report Adding twelve new widgets and a two reports Added a new report Added three more Widgets: Nodes by Capacity, Nodes by CPU Usage, Recently Discovered Nodes. Added six more widgets. Added a report Fixed two Reports Added fixed widget Added fixes to problems Fixed small bug in report Fixed small bugs in Reports Added small fixes to spec Fixed CRLF Added small changes in one of the reports Fixed some small line in report 130 Removed word widgets from titles Changes title at 'Number of nodes per CPU cores' widget Changed the name of 'Number of Nodes per CPU Core' widget renamed 'number of nodes per cpu' to 'nodes by cpu cores' Removed 'Nodes by CPU Cores' Changed spec accordingly

miq-bot · 2017-01-26T11:32:16Z

Checked commit nimrodshn@7409890 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍰

simon3z · 2017-01-26T15:06:10Z

@yaacov can you ack if it looks good?

yaacov · 2017-01-26T15:10:50Z

LGTM 👍

simon3z · 2017-01-26T16:09:09Z

LGTM 👍 cc @gtanzillo

@miq-bot assign gtanzillo

simon3z · 2017-02-10T14:14:26Z

Ping @gtanzillo @lavenel @chessbyte

gtanzillo

👍 LGTM

miq-bot added the providers/containers label Dec 8, 2016

chessbyte added the wip label Dec 8, 2016

nimrodshn force-pushed the Reports_20161014_095631 branch from 1df652d to 758ca20 Compare December 29, 2016 13:40

simon3z reviewed Jan 2, 2017

View reviewed changes

nimrodshn changed the title ~~[WIP] Adding new report and widgets~~ Adding new report and widgets Jan 4, 2017

nimrodshn force-pushed the Reports_20161014_095631 branch 7 times, most recently from d46e76b to b756b38 Compare January 5, 2017 11:08

chessbyte removed the wip label Jan 5, 2017

chessbyte assigned simon3z Jan 5, 2017

nimrodshn force-pushed the Reports_20161014_095631 branch 2 times, most recently from c24b7d8 to 613a381 Compare January 11, 2017 10:01

nimrodshn closed this Jan 11, 2017

nimrodshn reopened this Jan 11, 2017

nimrodshn closed this Jan 12, 2017

nimrodshn reopened this Jan 12, 2017

nimrodshn force-pushed the Reports_20161014_095631 branch from 5929a52 to 983d5ab Compare January 25, 2017 10:18

nimrodshn force-pushed the Reports_20161014_095631 branch 4 times, most recently from 756f72c to d5a3b3b Compare January 26, 2017 10:26

nimrodshn force-pushed the Reports_20161014_095631 branch from d5a3b3b to 7409890 Compare January 26, 2017 11:30

miq-bot assigned gtanzillo and unassigned simon3z Jan 26, 2017

gtanzillo approved these changes Feb 10, 2017

View reviewed changes

gtanzillo added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 10, 2017

gtanzillo merged commit a883256 into ManageIQ:master Feb 10, 2017

gtanzillo added core/reporting enhancement labels Feb 13, 2017

nimrodshn mentioned this pull request Mar 24, 2017

Link recently_discovered_pods widget to rpt #14493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding new report and widgets #13055

Adding new report and widgets #13055

nimrodshn commented Dec 8, 2016 •

edited by miq-bot

Loading

miq-bot commented Dec 8, 2016

zeari commented Dec 8, 2016

zeari commented Dec 8, 2016 •

edited

Loading

simon3z commented Dec 12, 2016

nimrodshn commented Dec 12, 2016 •

edited

Loading

nimrodshn commented Dec 28, 2016 •

edited

Loading

nimrodshn commented Dec 29, 2016

simon3z Jan 2, 2017

simon3z commented Jan 2, 2017

nimrodshn commented Jan 2, 2017

nimrodshn commented Jan 4, 2017 •

edited

Loading

simon3z commented Jan 20, 2017

yaacov commented Jan 20, 2017

nimrodshn commented Jan 25, 2017 •

edited

Loading

simon3z commented Jan 25, 2017

nimrodshn commented Jan 25, 2017

simon3z commented Jan 25, 2017

nimrodshn commented Jan 26, 2017

simon3z commented Jan 26, 2017

nimrodshn commented Jan 26, 2017 •

edited

Loading

nimrodshn commented Jan 26, 2017 •

edited

Loading

miq-bot commented Jan 26, 2017

simon3z commented Jan 26, 2017

yaacov commented Jan 26, 2017

simon3z commented Jan 26, 2017

simon3z commented Feb 10, 2017

gtanzillo left a comment

Adding new report and widgets #13055

Adding new report and widgets #13055

Conversation

nimrodshn commented Dec 8, 2016 • edited by miq-bot Loading

miq-bot commented Dec 8, 2016

zeari commented Dec 8, 2016

zeari commented Dec 8, 2016 • edited Loading

simon3z commented Dec 12, 2016

nimrodshn commented Dec 12, 2016 • edited Loading

nimrodshn commented Dec 28, 2016 • edited Loading

nimrodshn commented Dec 29, 2016

simon3z Jan 2, 2017

Choose a reason for hiding this comment

simon3z commented Jan 2, 2017

nimrodshn commented Jan 2, 2017

nimrodshn commented Jan 4, 2017 • edited Loading

simon3z commented Jan 20, 2017

yaacov commented Jan 20, 2017

nimrodshn commented Jan 25, 2017 • edited Loading

simon3z commented Jan 25, 2017

nimrodshn commented Jan 25, 2017

simon3z commented Jan 25, 2017

nimrodshn commented Jan 26, 2017

simon3z commented Jan 26, 2017

nimrodshn commented Jan 26, 2017 • edited Loading

nimrodshn commented Jan 26, 2017 • edited Loading

miq-bot commented Jan 26, 2017

simon3z commented Jan 26, 2017

yaacov commented Jan 26, 2017

simon3z commented Jan 26, 2017

simon3z commented Feb 10, 2017

gtanzillo left a comment

Choose a reason for hiding this comment

nimrodshn commented Dec 8, 2016 •

edited by miq-bot

Loading

zeari commented Dec 8, 2016 •

edited

Loading

nimrodshn commented Dec 12, 2016 •

edited

Loading

nimrodshn commented Dec 28, 2016 •

edited

Loading

nimrodshn commented Jan 4, 2017 •

edited

Loading

nimrodshn commented Jan 25, 2017 •

edited

Loading

nimrodshn commented Jan 26, 2017 •

edited

Loading

nimrodshn commented Jan 26, 2017 •

edited

Loading