Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor chargeback clean-up :: Move classification_for to ReportOptions #13227

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Dec 16, 2016

Minor chargeback clean-up.

Move classification_for to ReportOptions.

@miq-bot add_label refactoring, euwe/no
@miq-bot assign @gtanzillo

@isimluk isimluk changed the title [WIP] Minor chargeback clean-up :: Move classification_for to ReportOptions Minor chargeback clean-up :: Move classification_for to ReportOptions Dec 20, 2016
@isimluk
Copy link
Member Author

isimluk commented Dec 20, 2016

@miq-bot remove_label wip

1 similar comment
@isimluk
Copy link
Member Author

isimluk commented Dec 20, 2016

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Dec 20, 2016
@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2016

Checked commit isimluk@019a1eb with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🏆

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 51 Ending Jan 2, 2017 milestone Jan 3, 2017
@gtanzillo gtanzillo merged commit 33f2fe1 into ManageIQ:master Jan 3, 2017
@isimluk isimluk deleted the consumption-history-cleanup branch January 6, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants