Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Allocation chargebacks for SCVMM #13333

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Jan 3, 2017

What?

A spec for #13269. (Allocation CB for SCVMM)

This depens on #13331 (that one fixes rounding issue, for this test to pass)

@miq-bot add_label spec, chargeback, euwe/no, wip

@chessbyte chessbyte added the wip label Jan 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2017

@isimluk Cannot apply the following label because they are not recognized: spec

@isimluk isimluk force-pushed the remove-workarounds-from-tests branch from 7a85971 to 9e24887 Compare January 6, 2017 14:14
@isimluk isimluk changed the title [WIP] Chargeback: Remove a workaround from tests [WIP] Spec: Allocation chargebacks for SCVMM Jan 6, 2017
@isimluk isimluk force-pushed the remove-workarounds-from-tests branch 2 times, most recently from a3482b2 to 87f1d9b Compare January 6, 2017 14:32
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2017

This pull request is not mergeable. Please rebase and repush.

@isimluk isimluk force-pushed the remove-workarounds-from-tests branch from 87f1d9b to d712bfe Compare January 23, 2017 04:21
@isimluk
Copy link
Member Author

isimluk commented Jan 23, 2017

@miq-bot remove_label wip, unmergable
@miq-bot add_label specs

@isimluk isimluk changed the title [WIP] Spec: Allocation chargebacks for SCVMM Spec: Allocation chargebacks for SCVMM Jan 23, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2017

@isimluk Cannot remove the following label because they are not recognized: unmergable

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2017

@isimluk Cannot apply the following label because they are not recognized: specs

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2017

Checked commit isimluk@d712bfe with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2017

@isimluk Cannot apply the following label because they are not recognized: spec

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 23, 2017
@gtanzillo gtanzillo merged commit 9db73c8 into ManageIQ:master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants