Automate Retry with Server Affinity #13363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmcculloug @tinaafitz |
|
@mkanoor Looks good. This is a great enhancement. |
|
This pull request is not mergeable. Please rebase and repush. |
https://bugzilla.redhat.com/show_bug.cgi?id=1408850 A automate method retry can happen in any of the servers in the zone. If a customers automate method had started a process on a specific server, they would like to have the retry happen on the same server. This PR optionally allows an automate method to have the retries happen on the same server using an attribute in the $evm.root object accessible to automate methods. The name of the attribute is called ae_retry_server_affinity e.g. To enable the retry to happen on the same server use $evm.root['ae_retry_server_affinity'] = true
mkanoor
force-pushed
the
bugzilla_1408850
branch
from
03105e7
to
111120d
Compare
|
Checked commit mkanoor@111120d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@gmcculloug Changed it to euwe yes after our discussion |
mkanoor
added a commit
to mkanoor/manageiq
that referenced
this pull request
Jan 17, 2017
|
Backported to Euwe via #13543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An automate method retry can happen in any of the servers in the zone.
If a customers automate method had started a process on a specific
server, they would like to have the retry happen on the same server.
This PR optionally allows an automate method to have the retries happen
on the same server using an attribute in the $evm.root object accessible
to automate methods. The name of the attribute is called
ae_retry_server_affinity
e.g. To enable the retry to happen on the same server use
$evm.root['ae_retry_server_affinity'] = true
Links
Steps for Testing/QA
Create a multi server environment (zone)
Write a simple automate method that forces a retry along with some condition to prevent it from perpetually doing a retry
Incorporate the method into the provisioning workflow (the reason for this is so its delivered via the Queue)
Monitor the log file to see on which servers the methods were executed.
Please note that you can't try this with simulation since that doesn't go thru the queue