Don't charge hours before Vm/Container/Project was created #13373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When calculating average consumption (like Mhz) we divide consumption by number of hours in the interval. However, when VM gets created in the middle of the month, we should divide only by number of hours that the resource lived. Similarly, we should charge the consumption only for the hours that the resource existed.
Why
This becomes important for SCVMM. We charge for SCVMM without metric rollups. Hence, this case have higher chances to occur with SCVMM chargebacks. (Although it affects rollup-based chargebacks as well).
Note
This pr builds on top of #13134.
@miq-bot add_label chargeback, bug
@miq-bot assign @gtanzillo