Refactoring code of x_get_tree_custom_kids method #13402
Conversation
|
@miq-bot add_label refactoring |
|
Checked commit hstastna@6aa2893 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
hstastna
changed the title
hstastna
changed the title
hstastna
changed the title
| when "my" # My filters | ||
| visible_to_current_user | ||
| else | ||
| raise "Error: #{type} is not a proper type!" |
There was a problem hiding this comment.
I am thinking about this line. Do we need an error message?
If we do then it should probably say "filter type" not just "type".
There was a problem hiding this comment.
Thank you for your comment. I am not sure if we need an error message there, I considered it to be a good idea.. to think about all the cases that could occur somehow in the future..
I think, one shouldn't rely on the fact that maybe we don't need it. We should be sure if we need it or not. Maybe you or anybody else knows for sure..
If we need it, I can improve the error message.
depends on ManageIQ/manageiq-ui-classic#98 Refactoring code of x_get_tree_custom_kids method as the same code needs to be in the method in tree_builder_vms_filter.rb and in tree_builder_storage.rb; moving the code to new methods in miq_search.rb.
hstastna
force-pushed
the
x_get_tree_custom_kids_REFACTORING1
branch
from
6aa2893
to
08942e9
Compare
Refactoring code of x_get_tree_custom_kids method as the
same code needs to be in the method in tree_builder_vms_filter.rb
and in tree_builder_storage.rb;
moving the code to new methods in miq_search.rb.
This PR has to be merged with/before ManageIQ/manageiq-ui-classic#101!