Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MiqAeEngine components into the appropriate directory #13406

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jan 9, 2017

Move MiqAeEngine files into their own directory and simplify the require.

@bdunne
Copy link
Member Author

bdunne commented Jan 9, 2017

@mkanoor Please review.

cc @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2017

Some comments on commit bdunne@6d04e46

lib/miq_automation_engine/engine/miq_ae_engine/drb_remote_invoker.rb

  • ⚠️ - 118 - Detected puts. Remove all debugging statements.
  • ⚠️ - 119 - Detected puts. Remove all debugging statements.
  • ⚠️ - 120 - Detected puts. Remove all debugging statements.

lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_method.rb

  • ⚠️ - 121 - Detected puts. Remove all debugging statements.
  • ⚠️ - 190 - Detected puts. Remove all debugging statements.

@mkanoor mkanoor merged commit dd72efa into ManageIQ:master Jan 9, 2017
@mkanoor mkanoor added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 9, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2017

Checked commit bdunne@6d04e46 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
11 files checked, 0 offenses detected
Everything looks good. 👍

@bdunne bdunne deleted the miq_ae_engine branch January 9, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants