Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Fixed code that sets values of button_image, display & open_url fields #13415

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

h-kataria
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1401617

(cherry picked from commit e9c0b51)

Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.

Guidelines:

  • Keep Pull Request titles short and to the point, ideally under 72 characters
  • Provide as much context/info in the description as necessary to get the reviewer up to the same domain knowledge level as yourself
  • Keep code changes as short as possible and implementing a single feature/fix/refactoring, when possible

Links [Optional]

Steps for Testing/QA [Optional]

If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.

@chessbyte @simaishi @dclarizio please review, this is an EUWE PR for #13001

@chessbyte chessbyte changed the title [EUWE] - Fixed code that sets values of button_image, display & open_url fields [EUWE] Fixed code that sets values of button_image, display & open_url fields Jan 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2017

Checked commit h-kataria@914b6b5 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 1 offense detected

spec/controllers/application_controller/buttons_spec.rb

@simaishi simaishi merged commit b3ac2f8 into ManageIQ:euwe Jan 10, 2017
@simaishi simaishi modified the milestone: Sprint 52 Ending Jan 16, 2017 Jan 13, 2017
@h-kataria h-kataria deleted the backport_pr_13001 branch June 26, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants