[EUWE] Fix missing Smart State Analysis button on Cloud Instances list view #13422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analysis_missing Fix missing Smart State Analysis button on Cloud Instances list view (cherry picked from commit fb15bf9)
jzigmund
force-pushed
the
bz1404825-smartstate_analysis_missing
branch
from
ba8b520
to
b7a6e30
Compare
|
Checked commit jzigmund@b7a6e30 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/helpers/application_helper/buttons/basic_image_spec.rb
|
|
@romanblanco good catch, updated PR, though no side effects detected with the remaining line. I think it just unnecessary condition, as the |
|
@romanblanco @martinpovolny is this good to go? |
|
@simaishi LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original bugfix #12559
https://bugzilla.redhat.com/show_bug.cgi?id=1404825