Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Remove confirmation when opening the HTML5 vnc/spice console. #13465

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jan 12, 2017

EUWE version of: #12673

https://bugzilla.redhat.com/show_bug.cgi?id=1348721

1/2 of this was done as part of 9b38984 for Euwe.

@martinpovolny
Copy link
Member Author

@bmclaughlin or @mzazrivec : review, please?

@miq-bot miq-bot changed the title Remove confirmation when opening the HTML5 vnc/spice console. [EUWE] Remove confirmation when opening the HTML5 vnc/spice console. Jan 12, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2017

Checked commit martinpovolny@2b083ff with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

@martinpovolny
Copy link
Member Author

Closed by accident. @simaishi : reviewed, please, merge as it fits you.

@simaishi
Copy link
Contributor

@martinpovolny Can you reference PR for master?

@martinpovolny
Copy link
Member Author

@simaishi : added on top

@simaishi simaishi merged commit a0f78ce into ManageIQ:euwe Jan 13, 2017
@simaishi simaishi removed the euwe/yes label Jan 13, 2017
@simaishi simaishi modified the milestone: Sprint 52 Ending Jan 16, 2017 Jan 13, 2017
@martinpovolny martinpovolny deleted the bz_1412284 branch November 28, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants