Fix tier selection when using different units. #13593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug-2-wip
branch
from
dfaa42f
to
4656fac
Compare
isimluk
changed the title
|
@miq-bot remove_label wip, unmergeable |
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug-2-wip
branch
from
4656fac
to
bb2a2cf
Compare
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug-2-wip
branch
from
bb2a2cf
to
84fa4e5
Compare
|
Ping, any idea? |
miq-bot
changed the title
miq-bot
changed the title
|
@miq-bot what's up? |
Let's have it really strict and check interval boundaries.
Interestingly, the math for tiers was broken from day zero. In most cases however, rate_adjustoment=1, so this came unnoticed. This makes the new test green again.
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug-2-wip
branch
from
84fa4e5
to
671628d
Compare
|
Checked commits isimluk/manageiq@9e8094e~...671628d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was
Rates are tiered. Tier is selected based on the metrics' value.
When metric value and tier boundaries were in different units (metric in bytes, tiers in gigabytes), the tier selection was broken. We used
/operator instead of*.Cause
This problem existed since the day 0. It became just more visible after recent refactoring in #13331. I noticed that on one ocasion we had
value * rate_adjustmentand on another occasion we hadvalue / rate_adjustment. That begged for investigation.@miq-bot add_label chargeback, wip, bug
@miq-bot assign @gtanzillo