Adds remove_approver_resource to ServiceRequestController. #13596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
reviewed
Jan 20, 2017
| service_request.miq_approvals.find_by(:approver_name => user.name).destroy | ||
| end | ||
| rescue => err | ||
| raise BadRequestError, "Cannot remove approver - #{err}" |
There was a problem hiding this comment.
if the user is not an approver, the error message may not be nice, i.e. Cannot remove approver - undefined method `destroy' for nil:NilClass. Please check that case and simply not do the destroy (i.e. should just be a success since the user is not an approver). Thanks.
|
could you also take care of the rubocop warning ? Thanks!! |
cynepco3hahue
force-pushed
the
API_service_request_remove_approver
branch
from
cfcc18d
to
7131726
Compare
|
Checked commit cynepco3hahue@7131726 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
|
LGTM!! Thanks for the API enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desription
Adds remove_approver_resource to ServiceRequestController.
Links
Pivotal ticket