[EUWE] Make created filters in Datastores visible and fix commiting filters #13621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
changed the title
added 3 commits
January 23, 2017 15:55
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1414876 Display a new filter in Compute -> Infrastructure -> Datastores in My Filters in accordion right after creating it, no need to refresh the page to see the new filter there.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1414876 Make created filters in Compute -> Infrastructure -> -> Datastores visible under My Filters in accordion.
Fix commiting a new filter in advanced search panel which is related to its creating and saving because it did not work, button to 'Commit expression element changes' did not work properly. Also make button for discarding expression element changes work. Both buttons have the styling we need.
hstastna
force-pushed
the
Filters_in_datastores_page_refreshed2_EUWE_
branch
from
e3cd326
to
edcebc4
Compare
|
Checked commits hstastna/manageiq@bdee7e6~...edcebc4 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 app/controllers/application_controller/filter.rb
|
mzazrivec
approved these changes
Jan 23, 2017
|
looks good |
h-kataria
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing
https://bugzilla.redhat.com/show_bug.cgi?id=1414876
https://bugzilla.redhat.com/show_bug.cgi?id=1414870
https://bugzilla.redhat.com/show_bug.cgi?id=1382768
Make created filters (not global) in Compute -> Infrastructure -> Datastores
visible under My Filters in accordion, no need to refresh the page
after creating a new filter.
Fix commiting a new filter which is related to its creating and saving.
this PR resolves conflicts of backporting
ManageIQ/manageiq-ui-classic#98
and ManageIQ/manageiq-ui-classic#142
to euwe