Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide & show alert status actions #13650

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Jan 24, 2017

This should provide all the backend support needed to support hiding alert statuses for the alert screen.
Implemented using a new hide action_type

The api can be used to filter based on visibility:

localhost:3000/api/alerts?filter[]=hidden?=true&expand=resources

We also support making them visible again with a show action_type.

@moolitayer
Copy link
Author

@simon3z this will provide the feature we discussed. hidden != resolved

fyi @jeff-phillips-18 @serenamarie125 If we will choose to include this in the future,
it would require ability for new actions: hide & show as well ability to show/hide 'hidden' alerts.

@miq-bot
Copy link
Member

miq-bot commented Jan 24, 2017

Checked commit moolitayer@47f08d5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 2 offenses detected

app/models/miq_alert_status_action.rb

@moolitayer
Copy link
Author

@gtanzillo can you please review this PR or assign someone to review it

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 13, 2017
@gtanzillo gtanzillo merged commit ae43f33 into ManageIQ:master Feb 13, 2017
@moolitayer
Copy link
Author

Thanks for you time @gtanzillo 🍺

@gtanzillo
Copy link
Member

No problem @moolitayer 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants