Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract automation engine #13783

Merged
merged 3 commits into from
May 1, 2017
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Feb 6, 2017

Extract the automation engine to manageiq-automation_engine.

@bdunne bdunne force-pushed the extract_automation_engine branch 3 times, most recently from 74ca94c to 0f0bb4b Compare February 7, 2017 23:13
@bdunne
Copy link
Member Author

bdunne commented Feb 8, 2017

@Fryguy This is ready for review. Maybe we can sit together and discuss?

@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2017

This pull request is not mergeable. Please rebase and repush.

@bdunne bdunne force-pushed the extract_automation_engine branch 2 times, most recently from 6be5462 to 56c848b Compare March 30, 2017 14:03
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

This pull request is not mergeable. Please rebase and repush.

@bdunne bdunne closed this Apr 3, 2017
@bdunne bdunne reopened this Apr 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

This pull request is not mergeable. Please rebase and repush.

@bdunne bdunne changed the title [WIP] Extract automation engine Extract automation engine Apr 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2017

This pull request is not mergeable. Please rebase and repush.

@bdunne
Copy link
Member Author

bdunne commented Apr 19, 2017

Seems the last push didn't trigger Travis

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

Checked commits bdunne/manageiq@3aae2ca~...90d250e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@Fryguy Fryguy merged commit f5e8e47 into ManageIQ:master May 1, 2017
@Fryguy Fryguy added the fine/no label May 1, 2017
@Fryguy Fryguy added this to the Sprint 60 Ending May 8, 2017 milestone May 1, 2017
@bdunne bdunne deleted the extract_automation_engine branch May 1, 2017 18:08
@bdunne
Copy link
Member Author

bdunne commented May 1, 2017

Talk article for the announcement: http://talk.manageiq.org/t/automation-engine-extraction/2304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants