Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Project reports: add archived Container Groups #13810

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Feb 8, 2017

@zakiva
Copy link
Contributor Author

zakiva commented Feb 8, 2017

@miq-bot add_label providers/containers, bug, reporting

@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2017

Checked commit zakiva@0598ad4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@zakiva
Copy link
Contributor Author

zakiva commented Feb 8, 2017

@simon3z @zeari @gtanzillo Please review

@simon3z
Copy link
Contributor

simon3z commented Feb 8, 2017

@miq-bot assign @zakiva

We'll have to discuss if we want deleted Pods in the regular reports.

@simon3z
Copy link
Contributor

simon3z commented Feb 10, 2017

@zakiva can you add a screenshot of the relevant Report(s)

@zakiva
Copy link
Contributor Author

zakiva commented Feb 12, 2017

@zakiva can you add a screenshot of the relevant Report(s)

@simon3z This example report is based on Project including the project Name and Archived Container Groups fields: Name, Created on Time and Deleted On (there are other available fields, similar to regular pods):

archivedcreate

archived

@simon3z
Copy link
Contributor

simon3z commented Feb 21, 2017

@zakiva are both active and archived Pods displayed in the same report?
If so, is there a way to filter them? E.g. would it still be possible to make a report with only active Pods?

@zakiva
Copy link
Contributor Author

zakiva commented Feb 21, 2017

@zakiva are both active and archived Pods displayed in the same report?
If so, is there a way to filter them? E.g. would it still be possible to make a report with only active Pods?

@simon3z No, with current implementation archived and active pods are displayed in separate reports, so you can choose which "table" to include in the report (although it's the same table in the DB). The screenshots in my previous comment show a report based on archived pods and thus only archived pods are displayed.

For active pods there is no change in this PR, just need to choose them in the "Available Fields" list (as usual):

podsconfig

podsonly

@zakiva
Copy link
Contributor Author

zakiva commented Feb 28, 2017

@simon3z According to the comments in the BZ this fix supports the discussed use case.
@zeari @gtanzillo Can you please review?

@simon3z
Copy link
Contributor

simon3z commented Feb 28, 2017

LGTM 👍
cc @chessbyte

@miq-bot assign gtanzillo

@miq-bot miq-bot assigned gtanzillo and unassigned zakiva Feb 28, 2017
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 28, 2017
@gtanzillo gtanzillo merged commit 7297ab7 into ManageIQ:master Feb 28, 2017
@chessbyte chessbyte modified the milestones: Sprint 55 Ending Feb 27, 2017, Sprint 56 Ending Mar 13, 2017 Feb 28, 2017
@zakiva
Copy link
Contributor Author

zakiva commented Mar 2, 2017

@miq-bot add_label euwe/yes
cc @simon3z

simaishi pushed a commit that referenced this pull request Mar 8, 2017
Container Project reports: add archived Container Groups
(cherry picked from commit 7297ab7)

https://bugzilla.redhat.com/show_bug.cgi?id=1428130
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2017

Euwe backport details:

$ git log -1
commit 68667de3e47acaaee534ea1b9c6a4d076c74379a
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Feb 28 08:57:36 2017 -0500

    Merge pull request #13810 from zakiva/archived_pod_reports
    
    Container Project reports: add archived Container Groups
    (cherry picked from commit 7297ab74a61f7bb0a212c753ccc7a39b400dc446)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1428130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants