Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datawarehouse logger #13813

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Add datawarehouse logger #13813

merged 1 commit into from
Feb 13, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Feb 8, 2017 •
edited by miq-bot
Loading

Extracted from #12773

@moolitayer
Copy link
Author

@durandom @simon3z @cben please review

@miq-bot add_label enhancement, providers/containers

@moolitayer moolitayer mentioned this pull request Feb 8, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2017

Checked commit moolitayer@b0022e4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@moolitayer
Copy link
Author

@simon3z please review

1 similar comment
@moolitayer
Copy link
Author

@simon3z please review

@simon3z
Copy link
Contributor

simon3z commented Feb 9, 2017

LGTM 👍
cc @Fryguy @chessbyte

@miq-bot assign Fryguy

@miq-bot miq-bot assigned Fryguy and unassigned simon3z Feb 9, 2017
@moolitayer
Copy link
Author

@Fryguy @chessbyte could you please review/merge this?
I'm trying to keep patches small to merge them fast.
This adds a new log for the datawarehouse provider

@moolitayer
Copy link
Author

@Fryguy Ping

@moolitayer
Copy link
Author

@Fryguy can you review please

durandom
durandom approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight forward.
👍 for the size
personally, I would not have touched the indentation and just ignored rubocop

@Fryguy merge?

@Fryguy Fryguy merged commit 8e34d70 into ManageIQ:master Feb 13, 2017
@Fryguy Fryguy added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom approved these changes

Assignees

@Fryguy Fryguy

Labels
enhancement providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moolitayer @miq-bot @simon3z @durandom @Fryguy